Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in cmd/syncComparator.go causes build to fail #2423

Closed
tla5 opened this issue Oct 19, 2023 · 1 comment
Closed

Typo in cmd/syncComparator.go causes build to fail #2423

tla5 opened this issue Oct 19, 2023 · 1 comment

Comments

@tla5
Copy link

tla5 commented Oct 19, 2023

Which version of the AzCopy was used?

Attempting to build v10.21.0

Which platform are you using? (ex: Windows, Mac, Linux)

Alpine Linux 3.17.0
Golang 1.19.3

What command did you run?

git clone --depth 1 --branch v10.21.0 https://github.com/Azure/azure-storage-azcopy
cd azure-storage-azcopy
go build -o azcopy

What problem was encountered?

What appears to be a typo introduced in #2372 causes errors upon trying to build AzCopy from source:

$ go build
# github.com/Azure/azure-storage-azcopy/v10/cmd
cmd/syncComparator.go:117:77: undefined: syncOverwriteResaonNewerLMT

How can we reproduce the problem in the simplest way?

See above

Have you found a mitigation/solution?

Patching the file to fix the typo before building allows us to build the release successfully:

$ sed -i 's#syncOverwriteResaonNewerLMT#syncOverwriteReasonNewerLMT#g' cmd/syncComparator.go
$ go build -o azcopy
$ ./azcopy --version
azcopy version 10.21.0

It is apparently implemented in #2414

@gapra-msft
Copy link
Member

Hi, this has been resolved in our dev branch, as part of our next release, we will merge changes in the dev branch into main.

syncComparatorLog(sourceObjectInMap.relativePath, syncStatusOverwritten, syncOverwriteReasonNewerLMT, false)

Closing this for now since we are aware and it will be resolved as part of the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants