refresh purview-datamap-rest sdk #31356
Draft
+1,117
−754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
qiaozha
reviewed
Nov 7, 2024
| /** Resource for '/lineage/\{guid\}/next' has methods for the following verbs: get */ | ||
| (path: "/lineage/{guid}/next", guid: string): LineageGetNextPage; | ||
| /** Resource for '/lineage/\{guid\}/next/' has methods for the following verbs: get */ | ||
| (path: "/lineage/{guid}/next/", guid: string): LineageGetNextPage; |
There was a problem hiding this comment.
not sure if it would have impact on the end user?
| @@ -594,17 +547,17 @@ export interface QueryResultOutput { | |||
| * The total number of search results (not the number of documents in a single | |||
| * page). | |||
| */ | |||
| searchCount?: number; | |||
| "@search.count"?: number; | |||
There was a problem hiding this comment.
could you check the swagger or typespec for this?
| */ | ||
| relationshipCategory?: string; | ||
| relationshipCategory?: RelationshipCategoryOutput; |
There was a problem hiding this comment.
why this is changed from extensible enum into fixed enum?
|
|
||
| const client = getClient(baseUrl, credentials, options) as PurviewDataMapClient; | ||
| client.pipeline.removePolicy({ name: "ApiVersionPolicy" }); |
There was a problem hiding this comment.
this is the case where we shouldn't have client level apiVersion because not all operations have this parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#30680