You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It'd be a good idea to test other auth modes, OR if they are not necessary to improve test coverage, re-write the parameterized tests to only use the auth mechanism we need to test, and no longer be paremeterized. Otherwise, the following tests always get generated and skipped (regardless in CI or nightly/live mode).
Also, it is strange to see tests named _LIVEONLY_ run in PR/CI runs that are not liveonly.
Consider fixing that, so the name is applied only when the tests are actually run in live mode.
Some of the existing tables tests are configured to only run with connection string auth mode.
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4308778&view=logs&j=4dce5c19-e405-5fa0-33da-8863256ab80c&t=50966b7b-fb3e-5a8b-af38-b375d01c5327
It'd be a good idea to test other auth modes, OR if they are not necessary to improve test coverage, re-write the parameterized tests to only use the auth mechanism we need to test, and no longer be paremeterized. Otherwise, the following tests always get generated and skipped (regardless in CI or nightly/live mode).
For example:
azure-sdk-for-cpp/sdk/tables/azure-data-tables/test/ut/table_client_test.cpp
Lines 638 to 644 in 0e29b28
Also, it is strange to see tests named
_LIVEONLY_
run in PR/CI runs that are not liveonly.Consider fixing that, so the name is applied only when the tests are actually run in live mode.
For example:
https://dev.azure.com/azure-sdk/public/_build/results?buildId=4303796&view=logs&j=97d63481-2a2c-56b1-7542-28ff4f6c300c&t=77db9423-c813-5d44-8de0-ef1651559362
The name is being set here:
azure-sdk-for-cpp/sdk/tables/azure-data-tables/test/ut/table_client_test.cpp
Lines 781 to 794 in 0e29b28
The text was updated successfully, but these errors were encountered: