Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to port 50505 #523

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Change to port 50505 #523

merged 1 commit into from
Aug 10, 2023

Conversation

pamelafox
Copy link
Collaborator

Purpose

Port 5000 doesn't work well on many Macs due to a system process that uses 5000. You don't even get a port conflict error, it just silently fails to load :( I would love to not have to constantly change start.sh when I work on this repo, so I propose my favorite port, 50505.

This PR also removes the command the opens the browser. That command opens the browser before the app starts up, so you end up having to reload it anyway, and you have a moment of thinking it's broken. I think it's better to just click on the URL and open it once it's running.

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • cd app
  • ./start.sh
  • Click on URL in terminal
  • See local app

@tonybaloney tonybaloney merged commit 4255283 into Azure-Samples:main Aug 10, 2023
5 checks passed
HughRunyan pushed a commit to RMI/RMI_chatbot that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants