Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to enable AAD Auth/Authz #404

Closed
lenisha opened this issue Jul 10, 2023 · 10 comments
Closed

Add script to enable AAD Auth/Authz #404

lenisha opened this issue Jul 10, 2023 · 10 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request Stale

Comments

@lenisha
Copy link

lenisha commented Jul 10, 2023

This issue is for a: (mark with an x)

- [ ] bug report -> please search issues before submitting
- [x] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Expected/desired behavior

With the help of AppService Auth enable Authentication and Authorization for specific AAD group in the tenant

@lenisha lenisha added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 10, 2023
@pamelafox
Copy link
Collaborator

I've enabled AAD for the other sample:
https://github.com/Microsoft/sample-app-aoai-chatGPT/

I did it via preprovision and postprovision hooks, and some scripts to create the app registration.
Unfortunately, I haven't gotten it working on CI/CD yet, but it does work well locally.
Let me know if you'd like a PR to this repo for those changes.

@wherewith
Copy link
Contributor

I would love a PR to this repo for those changes!

@vrajroutu
Copy link

@wherewith also if you could display the user icon in the headers with the logged in user details.

@wherewith
Copy link
Contributor

I think that whatever solution was used on the other sample would be perfect for this repo as a starting point @pamelafox

@salvafuentes
Copy link

Yes please, it would be great to have some kind of authentication so not everyone can access the deploy.

@pamelafox
Copy link
Collaborator

PR at #534
Please report back if it works for you.

@pamelafox pamelafox changed the title Add ability/docs to enable AAD Auth/Authz Add script to enable AAD Auth/Authz Sep 25, 2023
@pamelafox
Copy link
Collaborator

We do have documentation now about using AAD but we'd like to automate it with scripts. @mattmsft is going to extend my scripts to work with the document-level access control he just added.

@zhongshuai-cao
Copy link

This is fantastic! I was hesitant to deploy the app initially and then manually integrate Azure AD later. Unfortunately, the official documentation didn't provide clear steps on how to achieve this using deployment scripts.

Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this issue will be closed.

@github-actions github-actions bot added the Stale label Dec 17, 2023
@mattgotteiner
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request Stale
Projects
None yet
Development

No branches or pull requests

7 participants