-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make a lib out of this good work #3
Comments
language support could be added one more interesting thing! Imagine a user can change the |
Hello! |
Hi! This is actually a great idea! Thanks Aylar. I suggest starting a new repo for the library. |
I'd prefer to move this under an organization/project. Pick a nice name for that and there you go. |
Indeed, appreciate your participation. @Aylarrazzaghi , think bigger, we gonna cover more languages. |
That's great! |
I would recommend only having one source of truth instead of copying the words across many repos that can end up out of sync and require duplicate effort. Moving the words into a JSON or Yaml format that people can edit/contribute to in this repo allows any library author to reference the JSON file from this repo and use the data in it in any way necessary. And to prevent duplicating within this repo we can use an automated build step to render the data from JSON to Markdown for the readme (similar to how the made-in-iran repo does it). The syntax (based on what data already exists in Readme) can be something like:
Although, if we want to support tone/language, we would need extra data that wouldn't fit in this syntax, and it might be better to have one file per word to have more room for adding extra data without making it unmaintainable. Personally, I don't see myself using a library as suggested, since depending on context/sentence structure it is almost always easier to use a well-established i18n library and use language files that can be passed to translators or crowdsourced. However, I can see tools (e.g. VisualStudio code plugins) being made that can use the JSON to search for words when making a UI without needing to go to google and disrupt the workflow. |
@d-fal Jan what do you think? |
Thanks @zumoshi There's an ongoing effort to enrich the corpus by @Aylarrazzaghi and it would be get more complete over the pace of the time. This corpus, indeed, would be computer readable format such as excel/csv, json, yaml etc. momentarily, I asked @Aylarrazzaghi to go ahead with GSheets. And yes, the Readme won't be like this as it's now. About having a vscode plugin, I like the idea 👍, we can definitely move in that direction as a byproduct. At the same time, I see further benefits for setting it up as a full-fledged library specifically for end users, not developers. |
@Aylarrazzaghi @d-fal If the GitHub organization hasn't been created yet, I can create a demo proposal for this idea using a new org. |
@SinaKarimi7 , |
@SinaKarimi7 @d-fal |
بنظرم ارگانیزیشن آپشن خاصی به شما نمیده که نیازتون باشه فقط دردسر اضافیه. فقط کافیه اصطلاحات رو در یک قالب مثل yaml در بیارید و با چند اسکریپت ساده لیست هارو generate کنید. |
Since there are many issues around UX-writing in Farsi and even non-Farsi sites, I would suggest to transfer it to a library and support many different languages.
I prefer something like this is js/ts for instance:
The text was updated successfully, but these errors were encountered: