Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE REQUEST | Lower Volume of Mic Clicks. #342

Open
ItsVinnyX opened this issue Aug 6, 2022 · 4 comments
Open

FEATURE REQUEST | Lower Volume of Mic Clicks. #342

ItsVinnyX opened this issue Aug 6, 2022 · 4 comments
Labels
todo Something that will be done in the future

Comments

@ItsVinnyX
Copy link

Feature Request
An option to lower the volume of the mic click sound effect.

@AvarianKnight AvarianKnight added the todo Something that will be done in the future label Sep 16, 2022
@nzkfc
Copy link

nzkfc commented Jan 19, 2023

Via a config, because everyone else just edits the audio files down.

@Gravxd
Copy link
Contributor

Gravxd commented Sep 14, 2023

Completed in #434 - at your discretion whether to take the code for personal use as it being merged is not a guarantee. :)

@Z3rio
Copy link

Z3rio commented Dec 1, 2023

@AvarianKnight This should be fine to close as completed, as far as I can see :)

@AvarianKnight
Copy link
Owner

This issue is being kept open due to the fact that I still want to implement this in a more intuitive way in the future.

As noted in the merge comment

I'm going to go ahead and merge this, but it should also be noted this will be removed in a future update (hopefully whenever I make a settings Ui for all voice related stuff)

This is still the plan whenever I get the time/motivation to work on it as having a way to save settings and persist them after a client restart would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
todo Something that will be done in the future
Projects
None yet
Development

No branches or pull requests

5 participants