Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom control should not be relative to device preview #86856

Closed
richtabor opened this issue Jan 25, 2024 · 3 comments
Closed

Zoom control should not be relative to device preview #86856

richtabor opened this issue Jan 25, 2024 · 3 comments
Labels
[Feature] Pattern Assembler The tool for building off of blank canvas using patterns. [Pri] Low Address when resources are available. [Type] Feature Request Feature requests

Comments

@richtabor
Copy link

I find it disorienting that the zoom control's effect was relative to the active device preview. The zoom control should perform exactly like the other device preview controls do—set the zoom/height/width/scale of the site.

It should not be a "combo" control that zooms each of the other previews, but it's own state of view. Otherwise it's quite confusing not understanding what view you're in, and how to get "back".

We wouldn't need to minus state of the button either. Just apply the same treatment as the other icons get when active. If I click on any other icon, the zoomed state should be omitted and the device preview state is active.

Safari.mp4
@richtabor richtabor added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Pattern Assembler The tool for building off of blank canvas using patterns. labels Jan 25, 2024
@github-actions github-actions bot added the [Pri] TBD Review and assign an appropriate [Pri] label as soon as possible. label Jan 25, 2024
@arthur791004
Copy link
Contributor

See p1706194641864719-slack-CRWCHQGUB

@cat-og cat-og moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Feb 2, 2024
@cat-og cat-og added [Pri] Low Address when resources are available. [Type] Feature Request Feature requests and removed [Type] Bug When a feature is broken and / or not performing as intended [Pri] TBD Review and assign an appropriate [Pri] label as soon as possible. labels Feb 2, 2024
@richtabor
Copy link
Author

Related in part to WordPress/gutenberg#58202, which is directionally how the editor will support zooming. You will not be able to stack zooming and device preview; they're agnostic. Each serves a distinct purpose: zooming alters the view scale, while device preview simulates how content would appear on different devices.

@taipeicoder
Copy link
Contributor

Closing this as we are sunsetting the Site Assembler.

@taipeicoder taipeicoder closed this as not planned Won't fix, can't repro, duplicate, stale Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Pattern Assembler The tool for building off of blank canvas using patterns. [Pri] Low Address when resources are available. [Type] Feature Request Feature requests
Development

No branches or pull requests

4 participants