Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full and wide width options missing from Site Editor #78707

Closed
jp-imagines opened this issue Jun 27, 2023 · 7 comments
Closed

Full and wide width options missing from Site Editor #78707

jp-imagines opened this issue Jun 27, 2023 · 7 comments
Labels
[Closed] By design Behaviors that are functioning as designed. [Platform] Atomic [Pri] Normal Schedule for the next available opportuinity. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. [Status] Needs Author Reply Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@jp-imagines
Copy link

Quick summary

Some blocks seem to have full and wide width alignment options in the post/page block editor, but not when editing the same content in the Site Editor.

Steps to reproduce

  1. Activate a block/FSE theme.
  2. Create a page and add a Slideshow or Gallery block to it. Save changes.
  3. Open the same page in the Site Editor.
  4. View the alignment options for the Slideshow or Gallery block in both editors.

What you expected to happen

There should be consistent settings in both editors.

What actually happened

In the Site Editor, full and wide with settings are missing:

knxW9G.png

Compared to the page editor:

5CVj3K.png

Impact

Most (> 50%)

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

Atomic

Logs or notes

Tested on Atomic so far, reproduced on Heiwa and Antonia. Unsure if this also affects simple or self-hosted sites.

Initially reported here: 6472568-zd-woothemes

For posts and pages (other than the latest posts page or default homepage), the settings are still available in the post/page block editor. For template-only pages, you need to add the affected block(s) into a Group with inner blocks use content width enabled for the options to be available.

@jp-imagines jp-imagines added [Type] Bug When a feature is broken and / or not performing as intended User Report labels Jun 27, 2023
@github-actions github-actions bot added [Platform] Atomic [Pri] Normal Schedule for the next available opportuinity. labels Jun 27, 2023
@github-actions
Copy link

Support References

This comment is automatically generated. Please do not edit it.

  • 6472568-zen

@cuemarie
Copy link

cuemarie commented Jun 28, 2023

Possibly related: WordPress/gutenberg#51685

@cuemarie
Copy link

Also possibly related: WordPress/gutenberg#45915

When a block that supports alignment (None, Wide, Full) is placed inside of a container (i.e. Group) and "
Inner blocks use content width" is toggled off in the contrainer, the alignment controls in the block toolbar of the child block should not display since they do nothing.

In other words, this may be by design in Core, but confusing, especially with the Post Content block on templates.

@cuemarie
Copy link

cuemarie commented Jun 28, 2023

Did more digging, and I think this guide from WordPress.org confirms this is by design: https://wordpress.org/documentation/article/layout-settings-overview/#customizing-layout-width

Toggle off Inner blocks use content width so that the nested inner blocks fill the width of the parent container.

Toggle on Inner blocks use content width so that the nested inner blocks use content width with options for full and wide widths.


My test on AT site with the Slideshow block matches this behavior:

T0ZyFe.mp4

📌 ACTIONS

  • Requested feedback

📌 Message to Author

  • @jp-imagines Just to check, do you think I've understood what you're reporting correctly here, based on the WPorg guidance above?

@cuemarie cuemarie added [Status] Needs Author Reply Triaged To be used when issues have been triaged. labels Jun 28, 2023
@jp-imagines
Copy link
Author

Just to check, do you think I've understood what you're reporting correctly here, based on the WPorg guidance above?

I think so.

The WPorg guidance makes some sense, but it's still very confusing. At least on my site (and I assume this is standard):

  • In the block editor, I can choose full or wide width options. There's no Group (or similar) block around the Slideshow etc. (from what can be seen in the page editor) to suggest that would be related.
  • If I access template editing through the page editor as in your video, I can see the Post Content block which (for my site) defaults to the inner blocks use content width setting enabled, and so the full and wide width options are still available. So far so good.
  • If I open that page in the Site Editor (via Appearance > Editor), the options are missing. The Post Content block is entirely locked, so the inner blocks use content width setting isn't even visible, and the missing alignment/width options suggests it's toggled off, which is inconsistent.

FUMIBY.png

  • If I then enable template editing from the Site Editor ("Page" tab > Edit template), the Post Content block is still locked, but I can see the inner blocks use content width setting which is enabled, which suggests the width settings should be available in the Site Editor. (In this view, I can't select those widths on individual blocks on the page, since the Post Content block is reverted to its placeholder state.)

Everything seems consistent except that you can't set the blocks to full or wide width when editing the page from Appearance > Editor, even though everything else suggests that you should be able to. You can also end up in a state where a block was set to full width from outside the Site Editor, but that option remains missing inside the Site Editor:

nWJY44.png

@cuemarie
Copy link

cuemarie commented Jun 28, 2023

Haha, you're definitely right, it is confusing @jp-imagines ! Appreciate the breakdown and screenshots.

As you've seen, I asked over here: p1687989204474379-slack-C03EUR81G3V for some help connecting this to any larger existing conversations in /gutenberg about the layout hierarchy that we're discussing. I think that'll help offer better context, and that'll be an AWESOME place to share the feedback and experience you just outlined!

@cuemarie
Copy link

cuemarie commented Jul 5, 2023

Ok, recapping some of the relevant conversations and next steps recommended in the thread above!

📌 ACTIONS

  • Closing as by design / in favor of the larger Gutenberg issues noted above

@cuemarie cuemarie closed this as not planned Won't fix, can't repro, duplicate, stale Jul 5, 2023
@cuemarie cuemarie added [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. [Closed] By design Behaviors that are functioning as designed. labels Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Closed] By design Behaviors that are functioning as designed. [Platform] Atomic [Pri] Normal Schedule for the next available opportuinity. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. [Status] Needs Author Reply Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

2 participants