Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make build-if-not-exists and build-if-changed always build #3211

Open
mokagio opened this issue May 31, 2024 · 2 comments
Open

make build-if-not-exists and build-if-changed always build #3211

mokagio opened this issue May 31, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@mokagio
Copy link
Contributor

mokagio commented May 31, 2024

That's because they look for dist/app.js but webpack uses fullhash in the name, i.e. dist/app.20fd562f4b5b27e29042.js

SIMPLENOTE_JS := $(THIS_DIR)/dist/app.js

filename: 'app.[fullhash].js',

@mokagio mokagio added the bug Something isn't working label May 31, 2024
@mokagio
Copy link
Contributor Author

mokagio commented Jun 24, 2024

That's because they look for dist/app.js but webpack uses fullhash in the name

This behavior was introduced in #1543

@codebykat
Copy link
Member

Right, I don't think we want to revert the hash, rather improve the Makefile detection... I tinkered with it a bit in #3225 but I'm not sure if that helps or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants