remoteData attribute is, in fact, optional (#177)

Automattic · Oct 23, 2024 · 79f4e7e · 79f4e7e
1 parent 2ab931b
commit 79f4e7e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/blocks/remote-data-container/components/field-shortcode/select-field-popover.tsx b/src/blocks/remote-data-container/components/field-shortcode/select-field-popover.tsx
@@ -43,10 +43,10 @@ export function FieldShortcodeSelectFieldPopover( props: FieldShortcodeSelectFie
 				</CardHeader>
 				<CardBody>
 					<FieldShortcodeSelectField
-						blockName={ props.fieldSelection.remoteData.blockName }
+						blockName={ props.fieldSelection.remoteData?.blockName ?? 'Remote Data Block' }
 						fieldType={ props.fieldSelection.type ?? 'field' }
 						onSelectField={ props.onSelectField }
-						queryInput={ props.fieldSelection.remoteData.queryInput }
+						queryInput={ props.fieldSelection.remoteData?.queryInput ?? {} }
 						selectedField={ props.fieldSelection.selectedField }
 					/>
 				</CardBody>

diff --git a/src/utils/block-binding.ts b/src/utils/block-binding.ts
@@ -97,7 +97,7 @@ export function hasBlockBinding(
 	);
 }
 
-export function hasRemoteDataChanged( one: RemoteData, two: RemoteData ): boolean {
+export function hasRemoteDataChanged( one?: RemoteData, two?: RemoteData ): boolean {
 	if ( ! one || ! two ) {
 		return true;
 	}

diff --git a/types/remote-data.d.ts b/types/remote-data.d.ts
@@ -25,7 +25,7 @@ interface RemoteData {
 }
 
 interface RemoteDataBlockAttributes {
-	remoteData: RemoteData;
+	remoteData?: RemoteData;
 }
 
 interface FieldSelection extends RemoteDataBlockAttributes {