-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package.json: Add packageManager field for corepack compatibility #40201
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
We didn't stay with 9.3.0 specifically. We don't want to constantly chase updates, so as long as things keep working we let the Probably we should also add something to the existing version checks to verify that this aligns with all the other pnpm version fields. |
So, I first tried 9.11 and one of the checks failed. I'll repush that to see what it was. |
I see, so it says this:
In reference to this which is also not autoupdating: Line 5 in 5878fb5
|
We could try this, is this too many static versions? I know @sgomes is currently trying to get JP to work in devbox without corepack (we're both using devbox now). Maybe we won't need this.. |
Ok, we found two ways to get JP to work in Devbox; but both require changing files committed to the repo.
|
I didn't have any objection to setting
Again, we don't really want to force a particular version of node on everyone. |
e91a24d
to
dedfb82
Compare
OK, I updated it to provide the info for corepack users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the linting check I had asked for earlier. If that looks good to you, let's go ahead.
Proposed changes:
packageManager
field topackage.json
to specify[email protected]
.This aligns with the version currently used in the GitHub Actions workflow and falls within the engines.pnpm range.
When using the repo with Devbox and Corepack, Corepack may attempt to download a newer pnpm version outside this range. Adding the packageManager field improves compatibility for Corepack users, ensuring consistency across local development and CI environments without impacting others.
I chose 9.3 specifically because it lines up with that's in the github actions.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: