Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General: Bump minimum PHP version to 7.2 #40147

Merged
merged 39 commits into from
Nov 13, 2024
Merged

General: Bump minimum PHP version to 7.2 #40147

merged 39 commits into from
Nov 13, 2024

Conversation

tbradsha
Copy link
Contributor

@tbradsha tbradsha commented Nov 12, 2024 •
edited
Loading

This bumps the minimum PHP version for our plugins to 7.2, matching the earliest version of WP we support (6.6).

This is listed as a major change.

The main changes are as follows:

  • Removed PHP 7.0 linting
  • Removed a now-unneeded version check in .phan/config.base.php
  • Bumped PHPCS configs and docs
  • Updated PHP versions in composer.json and readme.txt
  • Changed PHPUnit's setMethods() to onlyMethods() and addMethods() (note that the two instances of a null param were switched to an empty array)

I also ran across a "7.2" false positive referencing an old Gutenberg version (4.5 years old) in projects/packages/jetpack-mu-wpcom/src/features/starter-page-templates/page-patterns-plugin.tsx and removed the ternary.

To address in a separate PR:

  • codesniffer updates
  • other composer dependencies
  • a deeper look at various todos

Notes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Verify changes are valid and that CI checks are happy.

tbradsha and others added 12 commits November 12, 2024 09:35
@tbradsha
Bump minimum WP version to 6.6
b2a8652
@tbradsha
Match WP tested version to readme
4b760bf
@tbradsha
Add changelogs
993233f
@tbradsha
Remove 7.0 tests
b131376
@tbradsha
Update comments with more recent data
24d7af4
@tbradsha
Update composer.lock
eeddca7
@tbradsha
Fix comment
2ce5386
@Initsogar @tbradsha
Backup: Add next daily backup schedule time (#39914)
536f6cc 
* Set up react-query, moment and typescript

* changelog

* Add endpoint to fetch site backup schedule time

* Setup react-query (queryClientProvider)

* Add useScheduledTimeQuery hook to fetch schedule time

* Add hook to parse and return the next backup schedule time

* Add component to render the next scheduled backup message

* Fix record Tracks event

* Removing changelog for migration and core plugin

* Bump `Automattic\Jetpack\Backup` namespace to V0005

* changelog

* Bump `Automattic\Jetpack\Transport_Helper` to V0005

* Remove `between` to make `Modify` fit in the same line

* Fix pnpm lock
@tbradsha
Bump PHP 7.0 refs
dfa246e
@tbradsha
Clean up false positive
ffb403b
@tbradsha
setMethods → onlyMethods
df312f3
@tbradsha
Add changelogs
84800f8
@tbradsha tbradsha added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial labels Nov 12, 2024
@tbradsha tbradsha self-assigned this Nov 12, 2024
@tbradsha tbradsha marked this pull request as ready for review November 13, 2024 03:03
@tbradsha tbradsha requested a review from a team November 13, 2024 03:03
@jeherve jeherve mentioned this pull request Nov 13, 2024
Closed
@anomiex
Copy link
Contributor

anomiex commented Nov 13, 2024

Missed one:

jetpack/projects/packages/backup/composer.json

Line 7 in a70da82

"php": ">=7.0",

anomiex
anomiex approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it!

@tbradsha tbradsha merged commit e2ab2c1 into trunk Nov 13, 2024
72 of 73 checks passed
@tbradsha tbradsha deleted the update/bump_min_php_to_7.2 branch November 13, 2024 17:27
@github-actions github-actions bot removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Status] In Progress labels Nov 13, 2024
@tbradsha tbradsha mentioned this pull request Nov 13, 2024
Closed
@mikkamp mikkamp mentioned this pull request Nov 14, 2024
Open
@tbradsha tbradsha mentioned this pull request Nov 14, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anomiex anomiex anomiex approved these changes

Assignees

@tbradsha tbradsha

Labels
Actions GitHub actions used to automate some of the work around releases and repository management Docs [Feature] Calypsoify [Feature] Contact Form [Feature] Google Analytics [Feature] Masterbar WordPress.com Toolbar and Dashboard customizations [Feature] Photon aka "Image CDN". Feature developed in the Image CDN package and shipped in multiple plugins [Feature] Theme Tools [Feature] WooCommerce Analytics [Feature] WPCOM API [mu wpcom Feature] Starter Page Templates [Package] A8c Mc Stats [Package] Ad aka WordAds [Package] Admin Ui [Package] Analyzer [Package] Assets [Package] Autoloader [Package] Backup Helper Script Manager [Package] Backup [Package] Blaze [Package] Blocks [Package] Boost Core [Package] Boost Speed Score [Package] Calypsoify [Package] Changelogger [Package] Chatbot [Package] Classic Theme Helper [Package] Codesniffer [Package] Compat [Package] Composer Plugin [Package] Config [Package] Connection [Package] Constants [Package] Device Detection [Package] Error [Package] Explat [Package] Forms [Package] Google Analytics [Package] Ignorefile [Package] Image CDN [Package] Import [Package] IP [Package] Jetpack mu wpcom WordPress.com Features [Package] Jitm [Package] Licensing [Package] Logo [Package] Masterbar [Package] My Jetpack [Package] Password Checker [Package] Patchwork Redefine Exit [Package] Phpcs Filter [Package] Plans [Package] Plugin Deactivation [Package] Plugins Installer [Package] Post List [Package] Protect Models [Package] Protect Status [Package] Publicize [Package] Redirect [Package] Roles [Package] Scheduled Updates [Package] Schema [Package] Search Contains core Search functionality for Jetpack and Search plugins [Package] Stats Admin [Package] Stats Data [Package] Status [Package] Sync [Package] Transport Helper [Package] VideoPress [Package] WAF [Package] WooCommerce Analytics Enhanced analytics for WooCommerce users [Package] WP JS Data Sync [Package] Yoast Promo [Plugin] Automattic For Agencies Client [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Beta For serving live branches and the beta versions. https://github.com/automattic/jetpack-beta [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Classic Theme Helper Plugin [Plugin] CRM Issues about the Jetpack CRM plugin [Plugin] Inspect [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Migration [Plugin] mu wpcom jetpack-mu-wpcom plugin [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin [Plugin] Super Cache A fast caching plugin for WordPress. [Plugin] VaultPress [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. [Plugin] Wpcomsh [Tests] Includes Tests [Tools] Development CLI The tools/cli to assist during JP development. [Type] Janitorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tbradsha @anomiex @Initsogar