Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: lowercased dictionary words asking to be capitalized #77

Open
lukasmwerner opened this issue Apr 17, 2024 · 1 comment
Open

bug: lowercased dictionary words asking to be capitalized #77

lukasmwerner opened this issue Apr 17, 2024 · 1 comment

Comments

@lukasmwerner
Copy link
Contributor

When I added mTLS to my global dictionary the capitalization linter still attempts to capitalize the m with the diagnostic: This sentence does not start with a capital letter

Sample test case:

    - mTLS: mutual TLS
@elijah-potter
Copy link
Collaborator

The way I see it, the only situations where a sentence should not begin capitalized is if the first word is 1) a proper noun and 2) the given proper noun begins with a lowercase letter.

While the dictionary does include proper nouns, its goal is not to correct their capitalization. As such, I think the best course of action for this issue is to create a special dictionary for proper nouns, instances of which have strict capitalization requirements and may override the sentence capitalization linter.

I'll continue ruminating on the topic and update here when I have a final solution.
In the meantime, feel free to shout any and all potential ideas in my direction.

Thank you for letting me know about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants