-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What file extensions are supported ? #320
Comments
Harper doesn't aim to correct syntax errors or invalid code, that is the role of a language specific lsp. Those languages are "supported" because it will spellcheck comments on files of those types. |
Hey @motorto, It sounds like you're concerned because you are not getting language diagnostics when you provide invalid code to That's actually entirely expected. Harper doesn't aim to fix you're code, but rather your comments. Harper is actually a grammar checker, designed to make your non-code text easier to read and be understood by other people on your team. If you want confirmation that it's working, try adding a comment containing "This is an test". You should be getting diagnostics to fix it. Hope your day goes well :). Let me know if that answered your question so I can go ahead and close this ticket. |
Hey,
I was expecting that it would give grammar errors only on comments which it
doesn't.
I tried the sentence:
# This are error.
And get nothing.
The LspLogs doesn't give me nothing, and I can confirm that Harper is
running because of lspinfo.
Happy to help more, at the end of the day it might be a config problem on
my end. Can you confirm that it gives you grammar corrections in python
comments ?
…On Fri, Dec 20, 2024, 19:38 Elijah Potter ***@***.***> wrote:
Hey @motorto <https://github.com/motorto>,
It sounds like you're concerned because you are not getting language
diagnostics when you provide invalid code to harper-ls. Does that sound
right?
That's actually entirely expected. Harper doesn't aim to fix you're code,
but rather your comments. Harper <https://writewithharper.com> is
actually a grammar checker, designed to make your non-code text easier to
read and be understood by other people on your team.
If you want confirmation that it's working, try adding a comment
containing "This is an test". You should be getting diagnostics to fix it.
Hope your day goes well :). Let me know if that answered your question so
I can go ahead and close this ticket.
—
Reply to this email directly, view it on GitHub
<#320 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMRTQPOVYM3EIKZXOMUUJ5T2GRW43AVCNFSM6AAAAABT5DCIVWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJXGYYTMMJWHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Summary
The
harper_ls
language server, as documented in the [nvim-lspconfig documentation](https://github.com/neovim/nvim-lspconfig/blob/master/doc/configs.md#harper_ls), is supposed to support the following file types:However, while it works correctly for
markdown
andlua
files, no errors are being reported for other file types, even when no other LSP is active for the file.Steps to Reproduce
python
,c
, etc.) in Neovim.harper_ls
.Observed Behavior
harper_ls
works correctly formarkdown
files (errors are reported as expected).Expected Behavior
harper_ls
should provide diagnostics and error reporting for all supported file types listed in the documentation.Environment
Additional Notes
python
,c
, etc.).The text was updated successfully, but these errors were encountered: