Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: failing to detect non-Latinic alphabets as not English #254

Open
wadsaek opened this issue Oct 29, 2024 · 2 comments
Open

Bug: failing to detect non-Latinic alphabets as not English #254

wadsaek opened this issue Oct 29, 2024 · 2 comments

Comments

@wadsaek
Copy link

wadsaek commented Oct 29, 2024

As far as i know, Harper checks whether a piece of text is likely to be English, and it fails when seeing Ukrainian.
I'm using harper 0.12.0 from nixpkgs

image
image

might be connected to #113

@wadsaek wadsaek changed the title Bug: failing to decetc cyrillics as not english Bug: failing to detect Cyrillic as not English Oct 29, 2024
@wadsaek
Copy link
Author

wadsaek commented Oct 29, 2024

Same issue happens with Hebrew
image

@wadsaek wadsaek changed the title Bug: failing to detect Cyrillic as not English Bug: failing to detect non-Latinic alphabets as not English Oct 29, 2024
@elijah-potter
Copy link
Collaborator

elijah-potter commented Oct 29, 2024

As far as i know, Harper checks whether a piece of text is likely to be English, and it fails when seeing Ukrainian.

There is not yet a release of Harper that does this. The functionality exists in master but not in any official binary releases. Right now, I'm waiting on Mason to pick up changes before pushing out anything new.

That said, once it does get pushed out, I'll throw an update here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants