Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Beta] Release WP Job Manager 2.3.0 #2811

Closed
wants to merge 15 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
- name: Build Plugin
run: npm run build
- name: Decompress plugin
run: unzip wp-job-manager.zip -d wp-job-manager
run: unzip build/wp-job-manager.zip -d wp-job-manager
- name: Store Artifact
uses: actions/upload-artifact@v2
with:
Expand Down
15 changes: 0 additions & 15 deletions .psalm/psalm-baseline.xml
Original file line number Diff line number Diff line change
Expand Up @@ -402,21 +402,6 @@
<code><![CDATA[! defined( 'ABSPATH' )]]></code>
</ParadoxicalCondition>
</file>
<file src="lib/emogrifier/class-emogrifier.php">
<InvalidArgument>
<code><![CDATA[function ($matches) use (&$media) {
$media .= $matches[0];
}]]></code>
<code><![CDATA[usort($cssRules, [$this, 'sortBySelectorPrecedence'])]]></code>
</InvalidArgument>
<InvalidReturnStatement>
<code><![CDATA[$this->caches[self::CACHE_KEY_CSS][$cssKey]]]></code>
<code><![CDATA[$this->caches[self::CACHE_KEY_SELECTOR][$selectorKey]]]></code>
</InvalidReturnStatement>
<RedundantCondition>
<code><![CDATA[$node->parentNode && is_callable([$node->parentNode, 'removeChild'])]]></code>
</RedundantCondition>
</file>
<file src="lib/usage-tracking/class-wp-job-manager-usage-tracking-base.php">
<FalsableReturnStatement>
<code>false</code>
Expand Down
103 changes: 82 additions & 21 deletions assets/css/job-dashboard.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,14 @@
@import 'mixins';
@import 'job-overlay';

.jm-dashboard {
.jm-dashboard-table {
container-name: jm-dashboard-table;
container-type: inline-size;

--jm-dashboard-company-logo-size: calc(var(--jm-ui-icon-size) + 2 * var(--jm-ui-space-xs));

&.jm-dashboard-table--large {
container-name: jm-dashboard-table-large;
}
}

.jm-dashboard-job, .jm-dashboard-header {
Expand Down Expand Up @@ -42,14 +46,10 @@
.jm-dashboard-job-column {
flex: 1 1 calc(50% - var(--jm-ui-space-sm));
min-width: 0;
}

.jm-dashboard small {
font-size: var(--jm-ui-font-size-s);
}

.jm-dashboard .job_title {
flex: 1 1 200%;
line-height: 1.2;
small {
white-space: nowrap;
}
}

.jm-dashboard-job-column.company {
Expand Down Expand Up @@ -80,10 +80,6 @@
width: var(--jm-ui-icon-size-s);
height: var(--jm-ui-icon-size-s);
}

.job-status-rejected {
color: var(--jm-ui-error-color);
}
}

.jm-dashboard img.company_logo {
Expand All @@ -92,27 +88,47 @@
object-fit: contain;
}


.jm-dashboard-job-column.actions {
flex: 0.5 1 100%;
text-align: right;
display: flex;
justify-content: flex-end;
align-items: center;
gap: var(--jm-ui-space-m);
gap: var(--jm-ui-space-s);
}

.jm-dashboard-job-column a.job-title {
font-weight: 600;
font-size: var(--jm-ui-font-size);
line-height: 1.2;
text-decoration: unset;
}

.jm-dashboard-job-column a.job-title:hover {
text-decoration: underline;
}

.jm-dashboard-job-column-label {
text-transform: uppercase;
font-size: var(--jm-ui-font-size-s);
font-weight: 200;
color: fadeCurrentColor( 70% );
}

.jm-dashboard-job .jm-dashboard-job-column-label {
display: none;
}

.jm-dashboard small {
font-size: var(--jm-ui-font-size-s);
}

.jm-dashboard-table .job_title {
flex: 1 1 200%;
}

.jm-dashboard-table--large .job_title {
flex: 1 1 150%;
}

.jm-dashboard-action {
display: block;
text-decoration: none;
Expand All @@ -126,12 +142,33 @@
color: inherit;
}

.job-dashboard-action-delete {
.jm-dashboard .job-dashboard-action-delete {
color: var(--jm-ui-danger-color);
}

@container (width < 540px)
{
.jm-dashboard .job-manager-pagination {
ul.page-numbers {
display: flex;
flex-wrap: wrap;
align-items: center;
justify-content: center;
font-size: var(--jm-ui-font-size);
border: unset;
gap: 12px;
}
li {
min-width: 32px;
text-align: center;
border: 1px solid var(--jm-ui-border-light);
border-radius: 2px;

}
}

@mixin jm-dashboard-job-mobile {
.jm-dashboard-job-column:where(:not(.job_title):not(.actions):not(.company)) .jm-dashboard-job-column-label {
display: block;
}
.jm-dashboard-job {
flex-wrap: wrap;
align-items: flex-start;
Expand All @@ -149,4 +186,28 @@
flex-basis: calc( 100% - var(--jm-dashboard-company-logo-size) - var(--jm-ui-space-sm) );
order: -1;
}

}

@container jm-dashboard-table-large (width < 940px)
{
.jm-dashboard-job-column.job_title {
flex-basis: 100%;
}
}

@container jm-dashboard-table (width < 540px)
{
@include jm-dashboard-job-mobile;
}
@container jm-dashboard-table-large (width < 780px)
{
@include jm-dashboard-job-mobile;
}

@container jm-dashboard-table-large (540px < width < 780px)
{
.jm-dashboard-job-column {
flex: 1 1 calc(33% - 2 * var(--jm-ui-space-sm));
}
}
2 changes: 1 addition & 1 deletion assets/css/job-overlay.scss
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@
.jm-job-stats {

--jm-stat-color-page-view: var(--jm-ui-accent-color);
--jm-stat-color-unique-view: color-mix(in srgb, #000, var(--jm-stat-color-page-view) 40%);
--jm-stat-color-unique-view: var(--jm-ui-accent-alt-color);
}

.jm-job-stat-details {
Expand Down
4 changes: 4 additions & 0 deletions assets/css/ui.dialog.scss
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
}

.jm-dialog {
font-family: var(--jm-ui-font-family);
font-size: var(--jm-ui-font-size);
--jm-dialog-padding: var(--jm-ui-space-l);
}
Expand Down Expand Up @@ -54,6 +55,9 @@
overflow: auto;
overscroll-behavior: contain;

a:where(:not(:hover):not(:active):not(:focus)) {
color: var(--jm-ui-accent-color, #1a1a1a);
}
}
.jm-dialog-modal-container {
position: relative;
Expand Down
24 changes: 19 additions & 5 deletions assets/css/ui.elements.scss
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@

.jm-ui {
font-family: var(--jm-ui-font-family);
}

.jm-ui-row {
display: flex;
gap: var(--jm-ui-space-xs);
Expand Down Expand Up @@ -26,6 +30,7 @@
text-decoration: none;
outline: unset;
cursor: pointer;
border: unset;
}

.jm-ui-button,
Expand All @@ -51,6 +56,14 @@
}
}

a[href].jm-ui-button,
a[href].jm-ui-button--outline,
a[href].jm-ui-button--icon {
html body & {
text-decoration: none;
}
}

.jm-ui-button {
border: 1px solid currentColor;

Expand All @@ -67,13 +80,10 @@
}
}

.jm-ui-button--small,
.jm-ui-button--small
{
padding: var(--jm-ui-space-xxs) var(--jm-ui-space-s);
gap: var(--jm-ui-space-xs);
font-size: var(--jm-ui-font-size-s);
font-weight: 400;
letter-spacing: -0.1px;
}

.jm-ui-button__a {
Expand All @@ -83,6 +93,10 @@
.jm-ui-button--outline {
background: unset;
border: 1px solid currentColor;

&:hover, &:focus {
border: 1px solid currentColor;
}
}

.jm-ui-button--icon {
Expand Down Expand Up @@ -238,7 +252,7 @@
font-size: var(--jm-ui-font-size-s);
text-align: left;
white-space: nowrap;

line-height: 1.5;
display: flex;
flex-direction: column;
}
Expand Down
7 changes: 5 additions & 2 deletions assets/css/ui.neutral.scss
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,16 @@

--jm-ui-faint-color: #{fadeCurrentColor(2.5%)};
--jm-ui-accent-color: inherit;
--jm-ui-accent-alt-color: inherit;
--jm-ui-danger-color: #cc1818;
--jm-ui-error-color: #cc1818;
--jm-ui-danger-color-dark-mode: #f86c80;
--jm-ui-error-color: var(--jm-ui-danger-color);
--jm-ui-info-color: #4e71ec;
--jm-ui-success-color: #4ab866;
--jm-ui-accent-color-contrast: #ffffff;

--jm-ui-button-color: var(--jm-ui-accent-color, inherit);
--jm-ui-button-contrast: var(--jm-ui-accent-color-contrast, #ffffff);
--jm-ui-button-color-contrast: var(--jm-ui-accent-color-contrast, #ffffff);
--jm-ui-link-color: var(--jm-ui-accent-color, inherit);

--jm-ui-notice-error: var(--jm-ui-danger-color);
Expand All @@ -50,6 +52,7 @@
--jm-ui-space-xl: calc(16 * var(--jm-ui-space-base)); // 64px
--jm-ui-space-xxl: calc(24 * var(--jm-ui-space-base)); // 96px

--jm-ui-font-family: inherit;
--jm-ui-font-size: 16px;
--jm-ui-font-size-m: 14px;
--jm-ui-font-size-s: 12px;
Expand Down
2 changes: 0 additions & 2 deletions assets/js/job-dashboard.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

import domReady from '@wordpress/dom-ready';

import './ui';

// eslint-disable-next-line camelcase
const { i18nConfirmDelete, overlayEndpoint, statsEnabled } = job_manager_job_dashboard;

Expand Down
Loading
Loading