Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Company logo not displayed on mobile #1106

Closed
davoraltman opened this issue Jul 19, 2017 · 10 comments
Closed

Company logo not displayed on mobile #1106

davoraltman opened this issue Jul 19, 2017 · 10 comments

Comments

@davoraltman
Copy link

davoraltman commented Jul 19, 2017

The company logo is not being displayed when [jobs] page is viewed on mobile.

Thanks for taking a look!

604526-zen

@spencerfinnell
Copy link
Contributor

Which theme?

@davoraltman
Copy link
Author

I was able to reproduce on Twenty Sixteen.

@davoraltman
Copy link
Author

@jom Can you take a look at this one when you are back? Thanks!

@donnapep
Copy link
Contributor

Looks like it was a conscious decision to hide the logo at smaller resolutions, probably to avoid breaking the layout - https://github.com/Automattic/WP-Job-Manager/blob/master/assets/css/frontend.less#L888. Do we want to show the logo at all resolutions now?

@donnapep donnapep assigned donnapep and unassigned jom Aug 28, 2017
@davoraltman
Copy link
Author

@donnapep I'd say we do. Let's see what others think.

cc @dbtlr @annezazu @bikedorkjon

@annezazu
Copy link

I have no real authoritative opinion :/ I wonder if a mobile dev or a dev who really understands mobile dev could offer an opinion. Mine would be offered on shaky ground.

@donnapep donnapep removed their assignment Aug 31, 2017
@dbtlr
Copy link
Contributor

dbtlr commented Sep 1, 2017

I would need to evaluate some test cases to understand the pros and cons of showing vs hiding. @donnapep Do you think you could do some screenshots of this at various resolutions, with it shown and hidden, so we can see what it would look like?

@donnapep
Copy link
Contributor

donnapep commented Sep 1, 2017

@dbtlr Sure thing.

Here's iPhone 6 with no images (i.e. what it currently looks like):

iphone6-no-image

iPhone 6 with images:

iphone6-image

iPad with images (i.e. what it currently looks like):

ipad-image

So the smaller resolutions would need some work. It's not just a matter of turning the visibility of the image back on.

@dbtlr
Copy link
Contributor

dbtlr commented Sep 1, 2017

@donnapep Yeah, it seems like if we rearranged it to put the title on the top and the meta on the bottom, there would be plenty of room for the default style of have images in it on the left.

@jom
Copy link
Member

jom commented Mar 26, 2018

Closing but should inform our work on the new jobs block (#1287)

@jom jom closed this as completed Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants