-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Company logo not displayed on mobile #1106
Comments
Which theme? |
I was able to reproduce on Twenty Sixteen. |
@jom Can you take a look at this one when you are back? Thanks! |
Looks like it was a conscious decision to hide the logo at smaller resolutions, probably to avoid breaking the layout - https://github.com/Automattic/WP-Job-Manager/blob/master/assets/css/frontend.less#L888. Do we want to show the logo at all resolutions now? |
@donnapep I'd say we do. Let's see what others think. |
I have no real authoritative opinion :/ I wonder if a mobile dev or a dev who really understands mobile dev could offer an opinion. Mine would be offered on shaky ground. |
I would need to evaluate some test cases to understand the pros and cons of showing vs hiding. @donnapep Do you think you could do some screenshots of this at various resolutions, with it shown and hidden, so we can see what it would look like? |
@dbtlr Sure thing. Here's iPhone 6 with no images (i.e. what it currently looks like): iPhone 6 with images: iPad with images (i.e. what it currently looks like): So the smaller resolutions would need some work. It's not just a matter of turning the visibility of the image back on. |
@donnapep Yeah, it seems like if we rearranged it to put the title on the top and the meta on the bottom, there would be plenty of room for the default style of have images in it on the left. |
Closing but should inform our work on the new jobs block (#1287) |
The company logo is not being displayed when
[jobs]
page is viewed on mobile.Thanks for taking a look!
604526-zen
The text was updated successfully, but these errors were encountered: