Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task Templates no Pagination currently #27

Open
visch opened this issue Sep 8, 2021 · 2 comments
Open

Task Templates no Pagination currently #27

visch opened this issue Sep 8, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@visch
Copy link
Contributor

visch commented Sep 8, 2021

Just using the first page for task templates as it's not clear how to determine when you're out of pages (probably when you get 0 results). I want a test case to be sure I can test this

@visch
Copy link
Contributor Author

visch commented Sep 29, 2021

Both of our users so far have 2-10 task templates not close to 100. We can add this but it's not needed right now .

@visch visch added the enhancement New feature or request label Sep 29, 2021
@visch
Copy link
Contributor Author

visch commented Oct 21, 2021

Stream is here https://github.com/AutoIDM/tap-clickup/blob/main/tap_clickup/streams.py#L104
Example pagination is here: https://github.com/AutoIDM/tap-clickup/blob/main/tap_clickup/streams.py#L217

We could move pagination here

def get_next_page_token(
which would be much better. I'm just not sure if every stream supports pagination or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant