Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3D extraction across times at given depth #8

Open
raymondben opened this issue Nov 6, 2017 · 3 comments
Open

3D extraction across times at given depth #8

raymondben opened this issue Nov 6, 2017 · 3 comments

Comments

@raymondben
Copy link
Member

Probably related to #5.
romsdata3d will extract xyz data (2D at all depths for a given time index). There is an equivalent extraction (2D data at all times for a given depth index) for which angstroms doesn't have a convenience wrapper, but which would be handy.

@mdsumner
Copy link
Member

mdsumner commented Nov 6, 2017

Huh, good point - it only needs lvar = 3L to be available as an option, can you experiment with lvar-3 branch?

https://github.com/hypertidy/angstroms/blob/lvar-3/R/romsdata.R#L113

(brick doesn't handle the more general case, so lvar can't be 1 or 2 ... so doing this properly needs some attention)

@raymondben
Copy link
Member Author

That works a treat.

@mdsumner
Copy link
Member

mdsumner commented Nov 7, 2017

Now in master c0f450d

😨 ... should the first layer be the surface or the bottom? ...

I've set it up to match what I had before, i.e. layer 1 is the surface, and this matches the other conventions for slicing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants