Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add probabilistic line extraction #593

Open
tn3wman opened this issue Dec 6, 2021 · 5 comments
Open

Add probabilistic line extraction #593

tn3wman opened this issue Dec 6, 2021 · 5 comments

Comments

@tn3wman
Copy link

tn3wman commented Dec 6, 2021

I see circle fitting and rectangle fitting. It would be helpful to include probabilistic line extraction to detect walls in indoor environments. There are several implementations written in MATLAB here: https://github.com/acschaefer/ple

@AtsushiSakai
Copy link
Owner

PR is welcome. But note that the OSS’s license is GPL3.0, so we convert the code to Python is not acceptable. The code should be based on the original paper.

@AtsushiSakai
Copy link
Owner

@tn3wman
Copy link
Author

tn3wman commented Dec 16, 2021

Sounds good. I wasn't intending to convert the code from their research to Python, it's just the best example I have found with some implementations of more common algorithms such as iterative end point fit and split and merge. Hopefully it'll help troubleshoot issues with my own implementations, and if I get something working I'll create a PR.

@jpcoffelt
Copy link

I'd be interested in developing a Python solution from the source paper. Can this be assigned to me?

@AtsushiSakai
Copy link
Owner

Hi. Thank you for your interest. @jpcoffelt
Your PR is welcome. No need assignment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants