From 731d2cc1d5106c077584bd83e96dbba4f7e11118 Mon Sep 17 00:00:00 2001
From: Tom de Vries <tdevries@suse.de>
Date: Fri, 5 Aug 2022 08:09:57 +0200
Subject: [PATCH] [gdb] Add debug_{exp,val}

When debugging cc1 I heavily rely on simple one-parameter debug functions
that allow me to inspect a variable of a common type, like:
- debug_generic_expr
- debug_gimple_stmt
- debug_rtx
and I miss similar functions in gdb.

Add functions to dump variables of types 'value' and 'expression':
- debug_exp, and
- debug_val.

Tested on x86_64-linux, by breaking on varobj_create, and doing:
...
(gdb) call debug_exp (var->root->exp.get ())
&"Operation: OP_VAR_VALUE\n"
&" Block symbol:\n"
&"  Symbol: aaa\n"
&"  Block: 0x2d064f0\n"
(gdb)
...
and:
...
(gdb) call debug_val (value)
&"5"
(gdb)
...
---
 gdb/expprint.c           | 13 +++++++++++++
 gdb/valprint.c           | 12 ++++++++++++
 gdbsupport/common-defs.h |  6 ++++++
 3 files changed, 31 insertions(+)

diff --git a/gdb/expprint.c b/gdb/expprint.c
index cef6ffb3566..8534d2ac443 100644
--- a/gdb/expprint.c
+++ b/gdb/expprint.c
@@ -65,6 +65,19 @@ dump_prefix_expression (struct expression *exp, struct ui_file *stream)
   exp->op->dump (stream, 0);
 }
 
+/* Meant to be used in debug sessions, so don't export it in a header file.  */
+extern void ATTRIBUTE_USED debug_exp (struct expression *exp);
+
+/* Print EXP.  */
+
+void
+ATTRIBUTE_USED
+debug_exp (struct expression *exp)
+{
+  exp->op->dump (gdb_stdlog, 0);
+  gdb_flush (gdb_stdlog);
+}
+
 namespace expr
 {
 
diff --git a/gdb/valprint.c b/gdb/valprint.c
index f873e12d0ca..3ad4c0cd357 100644
--- a/gdb/valprint.c
+++ b/gdb/valprint.c
@@ -1190,6 +1190,18 @@ value_print (struct value *val, struct ui_file *stream,
   current_language->value_print (val, stream, options);
 }
 
+/* Meant to be used in debug sessions, so don't export it in a header file.  */
+extern void ATTRIBUTE_UNUSED debug_val (struct value *val);
+
+/* Print VAL.  */
+
+void ATTRIBUTE_UNUSED
+debug_val (struct value *val)
+{
+  value_print (val, gdb_stdlog, &user_print_options);
+  gdb_flush (gdb_stdlog);
+}
+
 static void
 val_print_type_code_flags (struct type *type, struct value *original_value,
 			   int embedded_offset, struct ui_file *stream)
diff --git a/gdbsupport/common-defs.h b/gdbsupport/common-defs.h
index eed364a48ce..e4985332e3f 100644
--- a/gdbsupport/common-defs.h
+++ b/gdbsupport/common-defs.h
@@ -191,6 +191,12 @@
 #define ATTRIBUTE_UNUSED_RESULT
 #endif
 
+#if (GCC_VERSION > 4000)
+#define ATTRIBUTE_USED __attribute__ ((__used__))
+#else
+#define ATTRIBUTE_USED
+#endif
+
 #include "libiberty.h"
 #include "pathmax.h"
 #include "gdb/signals.h"