web socket dose not work in socks5 proxy #1623
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slandelle
requested changes
Mar 13, 2019
client/src/main/java/org/asynchttpclient/netty/request/NettyRequestSender.java
Outdated
Show resolved
Hide resolved
slandelle
force-pushed
the
master
branch
5 times, most recently
from
6ea11f4
to
f8fab66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am in trouble when using web socket in socks5 proxy.
Motivation:
Here are 2 issues when I debug in code
1, when send request in socks5, client dose not send upgrade request because using http bootstrap , the http bootstrap dose not have wsHandler.
2, Can't not use socks5 domain resolve when client need.
I want write unit test for that but need a socks5 test server, it need spend some time. So I pull change first, others can check the code before it.
Modifications:
1, Modified ChannelManager getBootstrap logic when using socks proxy. Web socket using in socks proxy will use wsBootstrap for upgrade protocol handshake.
2, Proxy config add a domain resolver for setting bootstrap resolve. Use Netty NoopAddressResolverGroup for domain resolve in socks5 server, if you dose not set for this, it will use JDK default strategy for resolving.
Result:
After I mofidied those, my program run success
Forgive my poor English, it's not my native language...