-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not updating with Nova #162
Comments
Create a PR #163 that fixes this issue |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Any updates on publishing the PR? |
Hey, sorry for the delay. And thanks for your work. Except of the failing tests I have some fundamental questions about the issue. So far I've seen in the PR the issue is that Nova uses the |
Hei, I use this with my own personal version of switch-locale |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Btw, I have refactored and cleaned up the code a bit. It seems like Nova uses the singular due to it being just one field and it doesn't see it as a direct relationship, probably due to the abstraction that laravel-translatable does. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@u12206050 Did you find a solution to this? |
Yes am using the pull request that I made. ->translation
…On Tue, 16 Mar 2021, 08:27 Jess Stopa, ***@***.***> wrote:
@u12206050 <https://github.com/u12206050> Did you find a solution to this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#162 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSVMWX7GBAOWJAYXUG7O5LTD4B7XANCNFSM4PLSLPKQ>
.
|
Seems that this relates to #215 and is based in the usage of |
Describe the bug
I am using this with Nova, but none of the translatable fields seem to be updating.
To Reproduce
Install Nova v3
Setup a model and resource that is translatable
Create a new resource, and then try and update its fields
Only non-translatable fields are updated without any error
Expected behavior
All fields are updated
Versions (please complete the following information)
Exception
None
The text was updated successfully, but these errors were encountered: