Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting co-moving distances to physical distances #54

Open
bazkiaei opened this issue Mar 14, 2019 · 1 comment
Open

Converting co-moving distances to physical distances #54

bazkiaei opened this issue Mar 14, 2019 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@bazkiaei
Copy link
Contributor

The positions of particles in the simulations are co-moving distances. The code currently converts the view direction positions to the luminosity distances but it does not touch the positions in the plane of view. The difference between these two might be important so they should be converted to the physical distances.

@AnthonyHorton
Copy link
Member

If you want to be a perfectionist about this you'd want to also take into account the cosmological correction to the distances perpendicular to the line of sight. For significant redshifts the observed angular size of an object is not exactly physical_size / distance_from_observer. Look up 'angular size redshift relation'.

@lspitler lspitler added the help wanted Extra attention is needed label May 27, 2019
bazkiaei added a commit that referenced this issue Jul 3, 2019
A function to convert Pynbody distances to desired distances added to the code. This is half of the issue #54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants