Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a add_extended_source to gunagala #1

Open
lspitler opened this issue Aug 9, 2018 · 4 comments
Open

create a add_extended_source to gunagala #1

lspitler opened this issue Aug 9, 2018 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@lspitler
Copy link
Member

lspitler commented Aug 9, 2018

Perhaps based upon the existing PSF code? It would use the PSF that has been loaded to convolve the extended source & scale it according to the desired brightness.

@lspitler
Copy link
Member Author

lspitler commented Aug 9, 2018

Words of wisdom about this Issue from @AnthonyHorton on #mock_images on slack:

Yep. Could be developed outside of it initially, but would certainly want to integrate it once it's working.
Existing gunagala code works fine for creating a noiseless star field image (which is just an astropy.units.Quantity array). Then need to take a galaxy image, scale the pixel values (can use gunagala functions to convert surface brightnesses to electron/s/pixel or overall brightness to electrons/s), add it to the noiseless starfield image, then feed that result into the gunagala function to add noise. (edited)
Can do that stuff in the notebook for now.
That wouldn't end up convolving the galaxy image with the PSF, but I think that's the second step. That aspect really should be done inside gunagala.

@lspitler
Copy link
Member Author

This Issue is not really well-defined, but I think let's leave it open as it might be that we develop a solution that can later be adapted.

@lspitler
Copy link
Member Author

OK, I think will involve starting with the same gunagala code that places individual stars in an image. The only difference is that this new code will place an inputed image (e.g. a simulated galaxy), whereas the existing star code places the PSF (since stars are point sources).

@lspitler lspitler changed the title create a add_extended_source to gunagala create a add_extended_source to gunagala Sep 27, 2018
@bazkiaei bazkiaei added the help wanted Extra attention is needed label Oct 3, 2018
@bazkiaei
Copy link
Contributor

bazkiaei commented Oct 3, 2018

maybe just do this outside of gunagala first

@AnthonyHorton AnthonyHorton self-assigned this Oct 6, 2018
@lspitler lspitler added enhancement New feature or request and removed help wanted Extra attention is needed labels May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants