Skip to content

Commit

Permalink
Reworded some of the edit reasons
Browse files Browse the repository at this point in the history
These are up for debate
  • Loading branch information
AstroCB committed Oct 31, 2014
1 parent 7abdaeb commit 66d037a
Showing 1 changed file with 15 additions and 15 deletions.
30 changes: 15 additions & 15 deletions editor.user.js
Original file line number Diff line number Diff line change
Expand Up @@ -129,32 +129,32 @@ var main = function () {
so: {
expr: /(^|\s)[Ss]tack\s*overflow|StackOverflow(.|$)/gm,
replacement: "$1Stack Overflow$2",
reason: "'Stack Overflow' in improper format"
reason: "'Stack Overflow' is the proper capitalization"
},
se: {
expr: /(^|\s)[Ss]tack\s*exchange|StackExchange(.|$)/gm,
replacement: "$1Stack Exchange$2",
reason: "'Stack Exchange' in improper format"
reason: "'Stack Exchange' is the proper capitalization"
},
expansionSO: {
expr: /(^|\s)SO(\s|,|\.|!|\?|;|\/|\)|$)/gm,
replacement: "$1Stack Overflow$2",
reason: "'SO' expanded"
reason: "'SO' expansion"
},
expansionSE: {
expr: /(^|\s)SE(\s|,|\.|!|\?|;|\/|\)|$)/gm,
replacement: "$1Stack Exchange$2",
reason: "'SE' expanded"
reason: "'SE' expansion"
},
javascript: {
expr: /(^|\s)[Jj]ava\s*script(.|$)/gm,
replacement: "$1JavaScript$2",
reason: "'JavaScript' improper capitalization"
reason: "'JavaScript' is the proper capitalization"
},
jsfiddle: {
expr: /(^|\s)[Jj][Ss][Ff]iddle(.|$)/gm,
replacement: "$1JSFiddle$2",
reason: "'JSFiddle' improper capitalization"
reason: "'JSFiddle' is the currently accepted capitalization"
},
caps: {
expr: /^(?!https?)([a-z])/gm,
Expand All @@ -164,37 +164,37 @@ var main = function () {
jquery: {
expr: /(^|\s)[Jj][Qq]uery(.|$)/gm,
replacement: "$1jQuery$2",
reason: "'jQuery' improper capitalization"
reason: "'jQuery' is the proper capitalization"
},
html: {
expr: /(^|\s)[Hh]tml(?:5*)(\s|$)/gm,
replacement: "$1HTML$2",
reason: "HTML capitalized"
reason: "HTML: HyperText Markup Language"
},
css: {
expr: /(^|\s)[Cc]ss(\s|$)/gm,
replacement: "$1CSS$2",
reason: "CSS capitalized"
reason: "CSS: Cascading Style Sheets"
},
json: {
expr: /(^|\s)[Jj]son(\s|$)/gm,
replacement: "$1JSON$2",
reason: "JSON capitalized"
reason: "JSON: JavaScript Object Notation"
},
ajax: {
expr: /(^|\s)[Aa]jax(\s|$)/gm,
replacement: "$1AJAX$2",
reason: "AJAX capitalized"
reason: "AJAX: Asynchronous JavaScript and XML"

This comment has been minimized.

Copy link
@viziionary

viziionary Oct 31, 2014

Collaborator

don't understand the wording of these. The capitalization is what's fixed, not the word being spelled out. Seems like the purpose of showing the full word would be to inform people of what it means or to say "I spelled the full word out"

This comment has been minimized.

Copy link
@AstroCB

AstroCB Oct 31, 2014

Author Owner

@jt0dd They were meant to show why it was capitalized incorrectly: the original notes made this clearer, but I opted for a truncated version to keep in line with your intent of shortening the reasons. Again, they're up for debate, so feel free to change them to whatever you see fit (they're just suggestions).

This comment has been minimized.

Copy link
@viziionary

viziionary Oct 31, 2014

Collaborator

I'm gonna leave that call to you, but I think just "PHP capitalized" is going to be perfectly obvious and understandable to all involved.

This comment has been minimized.

Copy link
@AstroCB

AstroCB Oct 31, 2014

Author Owner

@jt0dd It's clear, but it sounds a bit abrupt and it could look odd when a bunch of terms are capitalized. It doesn't really matter to me either way, but I'll probably revise them later.

},
angular: {
expr: /[Aa]ngular[Jj][Ss]/g,
replacement: "AngularJS",
reason: "'AngularJS capitalization"
reason: "'AngularJS is the proper capitalization"
},
thanks: {
expr: /(thanks|please\s+help|cheers|regards|thx|thank\s+you|my\s+first\s+question).*$/gmi,
replacement: "",
reason: "'$1' in the question is just noise"
reason: "'$1' is unnecessary noise"
},
commas: {
expr: /,([^\s])/g,
Expand All @@ -204,12 +204,12 @@ var main = function () {
php: {
expr: /(^|\s)[Pp]hp(\s|$)/gm,
replacement: "$1PHP$2",
reason: "PHP capitalized"
reason: "PHP: PHP: Hypertext Preprocessor"

This comment has been minimized.

Copy link
@viziionary

viziionary Oct 31, 2014

Collaborator

Is PHP added twice there?

This comment has been minimized.

Copy link
@AstroCB
},
hello: {
expr: /(?:^|\s)(hi\s+guys|good\s(?:evening|morning|day|afternoon))(?:\.|!)/gmi,
replacement: "",
reason: "'$1' in the question is just noise"
reason: "Greetings like '$1' are unnecessary noise"
},
edit: {
expr: /(?:^\**)(edit|update):?(?:\**):?/gmi,
Expand Down

0 comments on commit 66d037a

Please sign in to comment.