Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(webview): re-enable webview renderer #568

Merged
merged 7 commits into from
Aug 9, 2024
Merged

Conversation

Ashinch
Copy link
Owner

@Ashinch Ashinch commented Jan 26, 2024

WebView remains the most stable rendering solution, and we should re-enable it, although some compatibility work still needs to be done between it and Compose.

  • Apply preference styles
  • Apply custom reading font
  • Support RTL languages
  • Pictures can be scaled and saved
  • Proxy image (use Referer header)
  • Support Bionic Reading
  • Support video

@Ashinch Ashinch added this to the 0.9.13 milestone Jan 30, 2024
@Ashinch Ashinch force-pushed the refactor-webview branch 2 times, most recently from 791be67 to 4f95e27 Compare February 6, 2024 17:54
@Ashinch Ashinch modified the milestones: 0.10.0, 0.11.0 Jun 2, 2024
@Ashinch Ashinch marked this pull request as ready for review July 8, 2024 08:47
@Ashinch Ashinch added the enhancement New feature or request label Jul 8, 2024
@aualbert
Copy link
Contributor

aualbert commented Jul 8, 2024

Great work! Here are some comments:

  • The scrollbar now behaves much better, but there is still a jump at the beginning. I guess this is due to title component before the actual content of the article. Could this be fixed quickly?
  • Math behaves a bit better, but i'll still try to add Katex in the webview. I can do this after this is merged. I'll ask a relevant question here: is it better to include the relevant Katex files in the project resources, or to write a task to add these files at build time only along the other generated ressources?

@Ashinch Ashinch force-pushed the refactor-webview branch 3 times, most recently from 5c72cd2 to 463f867 Compare July 16, 2024 02:26
@Ashinch Ashinch force-pushed the refactor-webview branch 2 times, most recently from 0e939b3 to dc36bc9 Compare July 24, 2024 09:58
@Ashinch Ashinch changed the title refactor(reading): re-enable webview renderer refactor(webview): re-enable webview renderer Aug 9, 2024
@Ashinch Ashinch merged commit b30ff86 into main Aug 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants