-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(webview): re-enable webview renderer #568
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ashinch
force-pushed
the
refactor-webview
branch
2 times, most recently
from
February 6, 2024 17:54
791be67
to
4f95e27
Compare
1 task
Great work! Here are some comments:
|
Ashinch
force-pushed
the
refactor-webview
branch
3 times, most recently
from
July 16, 2024 02:26
5c72cd2
to
463f867
Compare
Ashinch
force-pushed
the
refactor-webview
branch
2 times, most recently
from
July 24, 2024 09:58
0e939b3
to
dc36bc9
Compare
Ashinch
force-pushed
the
refactor-webview
branch
from
August 9, 2024 07:37
dc36bc9
to
2646586
Compare
Ashinch
force-pushed
the
refactor-webview
branch
from
August 9, 2024 08:41
2646586
to
c8aae45
Compare
Ashinch
force-pushed
the
refactor-webview
branch
from
August 9, 2024 10:46
16b72fe
to
04faa30
Compare
Ashinch
changed the title
refactor(reading): re-enable webview renderer
refactor(webview): re-enable webview renderer
Aug 9, 2024
This was referenced Aug 9, 2024
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebView remains the most stable rendering solution, and we should re-enable it, although some compatibility work still needs to be done between it and Compose.