Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to androidx.compose.material3.pulltorefresh #722

Closed
JunkFood02 opened this issue Jun 3, 2024 · 2 comments · Fixed by #850
Closed

Migrate to androidx.compose.material3.pulltorefresh #722

JunkFood02 opened this issue Jun 3, 2024 · 2 comments · Fixed by #850
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@JunkFood02
Copy link
Collaborator

Remove deprecated accompanist-swiperefresh from the app

Reference: https://google.github.io/accompanist/swiperefresh/
@JunkFood02 JunkFood02 added enhancement New feature or request good first issue Good for newcomers labels Jun 3, 2024
@Ashinch Ashinch added the help wanted Extra attention is needed label Jun 3, 2024
@aualbert
Copy link
Contributor

aualbert commented Jun 7, 2024

It seems like PullRefreshIndicator is not available in material3.pulltorefresh but only in material.pullrefresh. This functionality is used in SwipeRefresh.kt for example.

@JunkFood02
Copy link
Collaborator Author

There's an extension method provides the indicator in material3.pulltorefresh, but APIs seems to be changing in v1.3.+. We might need to wait for next compose update before working on this

@JunkFood02 JunkFood02 mentioned this issue Oct 9, 2024
Merged
@JunkFood02 JunkFood02 linked a pull request Oct 14, 2024 that will close this issue
Replace deprecated SwipeRefresh with recomended PullRefreshIndicator and implement pull to refresh for Feeds Page. #850
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
3 participants
@Ashinch @JunkFood02 @aualbert