Image shape + tool

[ashwinshres]

Can we give support for image addition as a shape layer just like any other drawing tool?

[stevelandeyasana]

This is possible and a PR would be welcome. There is one challenge: images can't be serialized in a self-contained way the same way as other shapes. Images should probably be stored by URL rather than bitmap data to avoid exploding the JSON blob size. This introduces a question of whether remote URLs should be supported—if so, there are also UI considerations to think about.

If you're only working with local file URLs, it should be roughly as complex as the rectangle shape + tool. Though from my experience writing drawing libraries, the very first GitHub issue opened after releasing that tool will be to request remote images. :-)

[ashwinshres]

Hey Steve, Thanks for the reply and providing the direction. Really appreciated it. Regards, Ashwin Shrestha

…

On Sat, Sep 14, 2019 at 9:17 PM Steve Landey ***@***.***> wrote: This is possible and a PR would be welcome. There is one challenge: images can't be serialized in a self-contained way the same way as other shapes. Images should probably be stored by URL rather than bitmap data to avoid exploding the JSON blob size. This introduces a question of whether remote URLs should be supported—if so, there are also UI considerations to think about. If you're only working with local file URLs, it should be roughly as complex as the rectangle shape + tool. Though from my experience writing drawing libraries, the very first GitHub issue opened after releasing that tool will be to request remote images. :-) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#33?email_source=notifications&email_token=ALX2FODSXM53772KW5CQQXLQJT72BA5CNFSM4IUEA232YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6W6BII#issuecomment-531488929>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALX2FOEHUYJI72TAN5CWORLQJT72BANCNFSM4IUEA23Q> .