Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Infinite Scroll's Controls #773

Open
7 tasks
Arthi-chaud opened this issue Oct 14, 2024 · 0 comments
Open
7 tasks

Rework Infinite Scroll's Controls #773

Arthi-chaud opened this issue Oct 14, 2024 · 0 comments
Assignees
Labels
Architecture Related to the project's Architecture and Framework Front Front-end related
Milestone

Comments

@Arthi-chaud
Copy link
Owner

Controls for Infinite Scrolls (infinte-xxx-view) work great, but the implementation is a bit old. We should rewrite them, so that:

  • The component is in charge of setting initial values (in SSR, from query parameters)
  • The component should be plug-n-play:
    • It should not handle sorting in a hard coded way, sorting keys/order should be passed through an Option object
    • Same for layout (grid/list)
    • Same for filtering songs by type
    • Same for filtering items by library
  • the parameters for infinite-xxx-view components should be more simple
@Arthi-chaud Arthi-chaud added Architecture Related to the project's Architecture and Framework Front Front-end related labels Oct 14, 2024
@Arthi-chaud Arthi-chaud added this to the v3.1.0 milestone Oct 14, 2024
@Arthi-chaud Arthi-chaud self-assigned this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Related to the project's Architecture and Framework Front Front-end related
Projects
None yet
Development

No branches or pull requests

1 participant