From 3764ebe8e5af869f4b7574a9a2586fe00e3bb80d Mon Sep 17 00:00:00 2001
From: Arslan-Siraj <arslan.siraj@uni-tuebingen.de>
Date: Mon, 2 Dec 2024 00:06:24 +0100
Subject: [PATCH] installation completion message & comment the run app
 directly after installation

---
 .../build-windows-executable-app.yaml         | 21 ++++++++++++++++---
 .../workflows/test-win-exe-w-embed-py.yaml    | 21 ++++++++++++++++---
 2 files changed, 36 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/build-windows-executable-app.yaml b/.github/workflows/build-windows-executable-app.yaml
index 95601f34..f589e6da 100644
--- a/.github/workflows/build-windows-executable-app.yaml
+++ b/.github/workflows/build-windows-executable-app.yaml
@@ -304,10 +304,18 @@ jobs:
       run: |
         ./wix/heat.exe dir streamlit_exe -gg -sfrag -sreg -srd -template component -cg StreamlitExeFiles -dr AppSubFolder -out streamlit_exe_files.wxs
     
+    - name: Generate VBScript file
+      shell: bash
+      run: |
+        cat <<EOF > ShowSuccessMessage.vbs
+        MsgBox "The ${{ env.APP_NAME }} application is successfully installed.", vbInformation, "Installation Complete"
+        EOF
+
     - name: Prepare SourceDir
       run: |
         mkdir SourceDir
         mv streamlit_exe/* SourceDir
+        cp ShowSuccessMessage.vbs SourceDir
         cp assets/openms_license.rtf SourceDir
         # Logo of app
         cp assets/openms.ico SourceDir
@@ -362,12 +370,19 @@ jobs:
             <Icon Id="AppIcon" SourceFile="SourceDir/openms.ico" />
         
             <!-- Run app directly after installation -->
-            <CustomAction Id="RunApp" Directory="AppSubFolder" Execute="deferred" Return="asyncNoWait" Impersonate="no"
-                          ExeCommand="cmd.exe /c &quot;[AppSubFolder]${{ env.APP_NAME }}.bat&quot;" />
+            <!-- <CustomAction Id="RunApp" Directory="AppSubFolder" Execute="deferred" Return="asyncNoWait" Impersonate="no"
+                          ExeCommand="cmd.exe /c &quot;[AppSubFolder]${{ env.APP_NAME }}.bat&quot;" /> -->
+            
+            <!-- Custom Action to Show Success Message -->
+            <Binary Id="ShowMessageScript" SourceFile="SourceDir/ShowSuccessMessage.vbs" />
+            <CustomAction Id="ShowSuccessMessage" BinaryKey="ShowMessageScript" VBScriptCall="" Execute="immediate" Return="check" />
         
             <!-- Add all Custom Actions -->
             <InstallExecuteSequence>
-              <Custom Action="RunApp" Before="InstallFinalize">NOT REMOVE</Custom>
+              <!-- Custom action display success message -->
+              <Custom Action="ShowSuccessMessage" After="InstallFinalize">NOT Installed</Custom>
+              <!-- Run app directly after installation -->
+              <!-- <Custom Action="RunApp" Before="InstallFinalize">NOT REMOVE</Custom> -->
             </InstallExecuteSequence>
         
             <!-- Interface options -->
diff --git a/.github/workflows/test-win-exe-w-embed-py.yaml b/.github/workflows/test-win-exe-w-embed-py.yaml
index 1bb8d6d8..ec8afc8f 100644
--- a/.github/workflows/test-win-exe-w-embed-py.yaml
+++ b/.github/workflows/test-win-exe-w-embed-py.yaml
@@ -93,10 +93,18 @@ jobs:
         run: |
           ./wix/heat.exe dir streamlit_exe -gg -sfrag -sreg -srd -template component -cg StreamlitExeFiles -dr AppSubFolder -out streamlit_exe_files.wxs
       
+      - name: Generate VBScript file
+        shell: bash
+        run: |
+          cat <<EOF > ShowSuccessMessage.vbs
+          MsgBox " The ${{ env.APP_NAME }} application is successfully installed.", vbInformation, "Installation Complete"
+          EOF
+
       - name: Prepare SourceDir
         run: |
           mkdir SourceDir
           mv streamlit_exe/* SourceDir
+          cp ShowSuccessMessage.vbs SourceDir
           cp assets/openms_license.rtf SourceDir
           # Logo of app
           cp assets/openms.ico SourceDir
@@ -151,12 +159,19 @@ jobs:
               <Icon Id="AppIcon" SourceFile="SourceDir/openms.ico" />
           
               <!-- Run app directly after installation -->
-              <CustomAction Id="RunApp" Directory="AppSubFolder" Execute="deferred" Return="asyncNoWait" Impersonate="no"
-                            ExeCommand="cmd.exe /c &quot;[AppSubFolder]${{ env.APP_NAME }}.bat&quot;" />
+              <!-- <CustomAction Id="RunApp" Directory="AppSubFolder" Execute="deferred" Return="asyncNoWait" Impersonate="no"
+                            ExeCommand="cmd.exe /c &quot;[AppSubFolder]${{ env.APP_NAME }}.bat&quot;" /> -->
+              
+              <!-- Custom Action to Show Success Message -->
+              <Binary Id="ShowMessageScript" SourceFile="SourceDir/ShowSuccessMessage.vbs" />
+              <CustomAction Id="ShowSuccessMessage" BinaryKey="ShowMessageScript" VBScriptCall="" Execute="immediate" Return="check" />
           
               <!-- Add all Custom Actions -->
               <InstallExecuteSequence>
-                <Custom Action="RunApp" Before="InstallFinalize">NOT REMOVE</Custom>
+                <!-- Custom action display success message -->
+                <Custom Action="ShowSuccessMessage" After="InstallFinalize">NOT Installed</Custom>
+                <!-- Run app directly after installation -->
+                <!-- <Custom Action="RunApp" Before="InstallFinalize">NOT REMOVE</Custom> -->
               </InstallExecuteSequence>
           
               <!-- Interface options -->