Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert disabling of external AudioManager.setSpeakerPhone(true) calls? #1

Open
jbaiter opened this issue Jan 22, 2021 · 0 comments
Open

Revert disabling of external AudioManager.setSpeakerPhone(true) calls? #1

jbaiter opened this issue Jan 22, 2021 · 0 comments

Comments

@jbaiter
Copy link

jbaiter commented Jan 22, 2021

Google decided to disable the possibility for external users to turn the speakerphone on when accepting calls with Android 10 in this commit: 0814db7

This breaks some apps and automation use cases, e.g. with Tasker. Would it be possible to re-enable this for ArrowOS by reverting the Google commit?

See https://issuetracker.google.com/issues/141889136 for more context and comments from users impacted by this change.
@jbaiter jbaiter changed the title Revert disabling of external AudioManager.setSpeakerPhone(trrue) calls? Revert disabling of external AudioManager.setSpeakerPhone(true) calls? Jan 22, 2021
arrowos-gerrit pushed a commit that referenced this issue Nov 8, 2022
switch TelecomManager List getters to ParceledListSlice
64b0a49 
It was shown that given a large phoneAccountHandles that are
over 1 mb, a TransactionTooLarge exception can be silently thrown
causing an empty list to be returned.

In order to prevent this behavior, all Lists that return a
PhoneAccountHandle or PhoneAccount have been switched to
ParceledListSlice.

bug: 236263294

Test: manual #1 - bug exists without fix,
      manual #2 - bug is fixed with patch,
      4 new CTS tests in
      android.telecom.cts.PhoneAccountRegistrarTest

Change-Id: Ibc3814dabd59cf9f0f9505b88f2146a4c3c5e015
Merged-In: Ibc3814dabd59cf9f0f9505b88f2146a4c3c5e015
(cherry picked from commit 963c5c7)
Merged-In: Ibc3814dabd59cf9f0f9505b88f2146a4c3c5e015
arrowos-gerrit pushed a commit that referenced this issue Dec 16, 2023
switch TelecomManager List getters to ParceledListSlice
404c0ca 
It was shown that given a large phoneAccountHandles that are
over 1 mb, a TransactionTooLarge exception can be silently thrown
causing an empty list to be returned.

In order to prevent this behavior, all Lists that return a
PhoneAccountHandle or PhoneAccount have been switched to
ParceledListSlice.

bug: 236263294

Test: manual #1 - bug exists without fix,
      manual #2 - bug is fixed with patch,
      4 new CTS tests in
      android.telecom.cts.PhoneAccountRegistrarTest

Change-Id: Ibc3814dabd59cf9f0f9505b88f2146a4c3c5e015
Merged-In: Ibc3814dabd59cf9f0f9505b88f2146a4c3c5e015
(cherry picked from commit 963c5c7)
Merged-In: Ibc3814dabd59cf9f0f9505b88f2146a4c3c5e015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jbaiter