Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible problem with cracking #1

Open
erich666 opened this issue Nov 5, 2018 · 2 comments
Open

Possible problem with cracking #1

erich666 opened this issue Nov 5, 2018 · 2 comments

Comments

@erich666
Copy link

erich666 commented Nov 5, 2018

For your image note that during rendering you could experience cracking, as the place where the two top rectangles meet the rightmost vertex on the smaller rectangle is not shared with the larger rectangle (subdivided into two triangles, which is how I can tell it's not shared). This is a T-junction, something to guard against. See say this article for more explanation.

cracking

@ArnaudValensi
Copy link
Owner

Good to know. But since all the vertices are at the same height and the object is static, meaning not animated, I think the issue is limited. I've never experienced a crack visible, but if it happens, I would know what to do, thanks.

@creationix
Copy link

Isn't the cracking issue because of approximations of floats in angled lines not quite matching up? I'm assuming that since this is a grid, all the rectangular lines are integers and exact values without rounding errors of any kind. (If for some reason, you scaled/rotated the grid so that corners landed on arbitrary float positions, then you might have problems)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants