新线索 Bug Fix #712
Open
新线索 Bug Fix #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mower-ng和mower不太一样，这边如果想改代码的话是提交到2024.12.1分支里面。 |
想请问一下现在mower的main branch还有在维护吗？如果想改mower-ng的代码的话应该怎么做？ |
PR之前麻烦看一下readme, NG 是分支，前开发携库跑路。 main branch 在2024.12.1 分支 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
麻烦各位大佬看一下，我用的code base source from：https://git.zhaozuohong.vip/mower-ng/mower-ng
这个repo和github的repo不太一样，但是苦于没有办法联系到repo owner，对于Forgejo不是很熟悉没有账号无法contribute，只能在这里post PR。
实际的code update route 应该是：mower-ng\mower\solvers\infra\clue_init_.py : ClueManager
标题: 修复线索满时无法收集每日线索的 bug
描述:
根据 Issue #557 “新线索” Bug-3 的修复。当线索数量满时，"DailySolver" 无法收集每日线索。旧代码中，
DailySolver.run()被调用在GiveAwaySolver和GetClueCountSolver之前，导致如果线索数量已满时，无法收集每日线索。变更内容:
GiveAwaySolver)； 2. 接着赠送线索 (GiveAwaySolver)；3. 最后收集每日线索 (DailySolver)。DailySolver.run()将在GiveAwaySolver之前调用以收集每日线索（DailySolver 会被call两次）Title: Fix bug where daily clues cannot be collected when clue count is full
Description:
This update fixes the issue where the "DailySolver" cannot collect daily clues when the clue count is full (i.e., 10). In the old code,
DailySolver.run()was called beforeGiveAwaySolverandGetClueCountSolver, preventing the collection of daily clues if the clue count was full.Changes:
GiveAwaySolver).GiveAwaySolver).DailySolver), but only if the clue count is not full (<= 9).DailySolver.run()will still be called beforeGiveAwaySolverto collect the daily clues.This fix ensures that the system will always collect daily clues when the clue count is not full and gives priority to giving away clues when necessary.