Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use .instrument(tracer_provider=tracer_provider) in our examples #372

Open
RogerHYang opened this issue Apr 12, 2024 · 1 comment
Open

use .instrument(tracer_provider=tracer_provider) in our examples #372

RogerHYang opened this issue Apr 12, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation examples Related to the examples in the repo help wanted Extra attention is needed

Comments

@RogerHYang
Copy link
Contributor

We should use .instrument(tracer_provider=tracer_provider) in our examples, instead of trace_api.set_tracer_provider(tracer_provider) because users may be working in a (production) system where there's an already an incumbent OTEL tracer provider (and exporter). This results in confusion because our instrumentor won't get the proper exporter and nothing gets exported.
@github-project-automation github-project-automation bot moved this to 📘 Todo in phoenix Apr 12, 2024
@dosubot dosubot bot added documentation Improvements or additions to documentation examples Related to the examples in the repo labels Apr 12, 2024
@mikeldking mikeldking added the triage Issues that require triage label Apr 12, 2024
@mikeldking mikeldking added help wanted Extra attention is needed and removed triage Issues that require triage labels Apr 29, 2024
@mikeldking
Copy link
Contributor

Removing triage flag for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation examples Related to the examples in the repo help wanted Extra attention is needed
Projects
phoenix
Status: 📘 Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikeldking @RogerHYang