Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement][js] Ensure auto-instrumentation is functional in ESM-only projects #1106

Open
cephalization opened this issue Nov 7, 2024 · 2 comments
Assignees
Labels
bug Something isn't working language: js Related to JavaScript or Typescript integration

Comments

@cephalization
Copy link
Contributor

cephalization commented Nov 7, 2024

Packages are now advertised as ESM, but does auto-instrumentation work under ESM-only projects?

While we build and ship ESM versions of our packages, we do not advertise their availability to module resolvers via package.json

We need to fill out the exports field.

See:

@github-project-automation github-project-automation bot moved this to 📘 Todo in phoenix Nov 7, 2024
@dosubot dosubot bot added bug Something isn't working language: js Related to JavaScript or Typescript integration labels Nov 7, 2024
@cephalization cephalization changed the title [bug][js] Expose ESM builds to node module resolver [enhancement][js] Expose ESM builds to node module resolver Nov 7, 2024
@cephalization
Copy link
Contributor Author

Additionally, we should evaluate if esm support actually works correctly.

See https://github.com/open-telemetry/opentelemetry-js/blob/main/doc/esm-support.md

for what the implications are when using these packages in esm-only applications

@cephalization
Copy link
Contributor Author

Also see #1144

@cephalization cephalization self-assigned this Dec 4, 2024
@cephalization cephalization moved this from 📘 Todo to 👨‍💻 In progress in phoenix Dec 4, 2024
@cephalization cephalization changed the title [enhancement][js] Expose ESM builds to node module resolver [enhancement][js] Ensure auto-instrumentation is functional in ESM-only projects Dec 12, 2024
@mikeldking mikeldking moved this from 👨‍💻 In progress to 📘 Todo in phoenix Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working language: js Related to JavaScript or Typescript integration
Projects
Status: 📘 Todo
Development

No branches or pull requests

1 participant