Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtitle position differs from FFmpeg #14

Closed
Arcus92 opened this issue Oct 30, 2024 · 1 comment · Fixed by #16
Closed

Subtitle position differs from FFmpeg #14

Arcus92 opened this issue Oct 30, 2024 · 1 comment · Fixed by #16
Assignees
Labels
bug Something isn't working

Comments

@Arcus92
Copy link
Owner

Arcus92 commented Oct 30, 2024

There are two different concepts for positioning in PGS. A composition defines a simple x, y coordinate to render, but also a window - a rectangle with x, y, width and height.

Currently this lib uses the window position, however FFmpeg uses the composition position.

I guess the composition position always lays in the window rect, but is just more precise. So I should change it to match the FFmpeg position and check how it works. I will still use the full window for clearing.

@Arcus92
Copy link
Owner Author

Arcus92 commented Oct 30, 2024

For more context: jellyfin/jellyfin-web#6273

@Arcus92 Arcus92 self-assigned this Oct 30, 2024
@Arcus92 Arcus92 added the bug Something isn't working label Oct 30, 2024
@Arcus92 Arcus92 linked a pull request Oct 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant