Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Component.cli is unused when using Component.func #4269

Open
qwint opened this issue Nov 27, 2024 · 0 comments
Open

Bug: Component.cli is unused when using Component.func #4269

qwint opened this issue Nov 27, 2024 · 0 comments

Comments

@qwint
Copy link
Contributor

qwint commented Nov 27, 2024

What happened?

recreated by setting Text Client's Component.cli=True, opening the launcher gui, clicking on text client, and seeing nothing change
then leaving cli=True but removing the func definition in the component, redoing the same steps, and seeing a new terminal for the text client as expected

I also couldn't find a way to make this functionality actually work using Component.func so resolution of the bug may just be documenting that it is only applicable for Components not using func (and I can add that info to #4148 if needed)

What were the expected results?

like when using Compnent.script_name setting cli=True would spawn a new terminal window to launch the component in

Software

While playing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant