Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify NameTypeConnectionInformant #1

Open
Hossiphi opened this issue Oct 28, 2022 · 0 comments
Open

Simplify NameTypeConnectionInformant #1

Hossiphi opened this issue Oct 28, 2022 · 0 comments
Assignees
@Hossiphi

Comments

@Hossiphi
Copy link
Member

Hossiphi commented Oct 28, 2022 •
edited
Loading

NameTypeConnectionInformant in the InitialConnectionAgent currently searches for model types.
However, this is already done by the NameTypeInformant of the InitialRecommendationAgent.

  1. It should be checked, whether it makes a different for the confidences of the RIs, if the additional classification is taken away.
  2. The NameTypeInformant can simply check RecommendedInstances instead of all words.
  3. Matching Instances should not be selected via SimilarityUtils.areWordsOfListsSimilar(), but with isNounMappingSimilarToModelInstance()
  4. The assumption that there's just one similar instance to a word should not be implicit
@dfuchss dfuchss transferred this issue from ArDoCo/Core Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hossiphi Hossiphi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Hossiphi