Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing CleverReach integration to check if it is a text mailing rather than use a default value #6

Open
gitfvb opened this issue Nov 16, 2023 · 3 comments
Open

Changing CleverReach integration to check if it is a text mailing rather than use a default value #6

gitfvb opened this issue Nov 16, 2023 · 3 comments
Assignees
@gitfvb
Labels
enhancement New feature or request

Comments

@gitfvb
Copy link
Contributor

gitfvb commented Nov 16, 2023

At the moment we just use html/text as a default value in the type for mailing creation, but this could also be text or html

This could be read from the mailing lookup:

m_type = 1 -> text
m_type = 2 -> html
m_type = 3 -> html/text
@gitfvb gitfvb self-assigned this Nov 16, 2023
@gitfvb gitfvb added the enhancement New feature or request label Nov 16, 2023
@gitfvb
Copy link
Contributor Author

gitfvb commented Nov 16, 2023

Tests were successful, issue can be closed after deprecated the default parameter.

@gitfvb
Copy link
Contributor Author

gitfvb commented Nov 17, 2023

Hints after testing of a user:

  • Add hints about the usage of textmails
  • Check if preview is possible with textmails, too
  • Send seems to fail for text mails, when a preheader is used in Apteco -> check

gitfvb added a commit that referenced this issue Nov 17, 2023
@gitfvb
Adding more debug information to #6
0b1331b
@gitfvb
Copy link
Contributor Author

gitfvb commented Nov 21, 2023

Published the changes until now in 0.1.8 and 0.2.0, but there will be more changes in the upcoming releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gitfvb gitfvb

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

6-changing-cleverreach-integration-to-check-if-it-is-a-text-mailing-rather-than-use-a-default-value Apteco/AptecoPSFramework
1 participant
@gitfvb