Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce websocket for some updates from the server #54

Open
4 tasks
gomoripeti opened this issue Mar 5, 2017 · 1 comment
Open
4 tasks

Introduce websocket for some updates from the server #54

gomoripeti opened this issue Mar 5, 2017 · 1 comment

Comments

@gomoripeti
Copy link
Collaborator

Some of the REST endpoints (that are currently polled by the front end) could be replaced by websocket notifications from the server:

these definitely as they usually don't return new info

  • "api/trace_status"
  • "api/mon_get_all"

maybe these too:

  • "api/capture_data"
  • "api/data"
@afronski afronski added this to the 1.3.0 milestone Apr 25, 2017
@afronski
Copy link
Contributor

afronski commented Apr 25, 2017

I would add to it a small finding (not confirmed yet for 100%) - due to setTimeout and setState interleaved calls we are building up memory (plus consuming a lot of CPU for each frame) which sometimes leads to Aw snap! in Google Chrome and crashed tab.

My suggestion would be to stick to requestAnimationFrame (leveraging virtual DOM and React) and WS connection, and provide updates in more event-base fashion.

@gomoripeti gomoripeti removed this from the 1.3.0 milestone Feb 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants