Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for zstd compression to libappimage #68

Closed
philmb3487 opened this issue Sep 18, 2024 · 3 comments
Closed

Add support for zstd compression to libappimage #68

philmb3487 opened this issue Sep 18, 2024 · 3 comments

Comments

@philmb3487
Copy link

philmb3487 commented Sep 18, 2024

There seems to be an issue with icon generation on a newer runtime of appimagetool.

Could someone with more experience have a look at the bug report I filed here?
ivan-hc/Steam-appimage#27

Where is the snafu with image generation in this case?

thumbnail managers should adapt to the work of AppImage packagers, not the other way around

Is this the policy of the project?

Thanks!

@probonopd
Copy link
Member

probonopd commented Sep 20, 2024

Can you summarize what is the issue there and how we might be able to help?

An AppImage thumbnailer would need to retrieve the .DirIcon from inside the AppImage.

@philmb3487
Copy link
Author

philmb3487 commented Sep 21, 2024

Yes, I can summarize. The gist of it is that some people are generating AppImages with zstd compression, and that is not supported out of the box by libappimage.
Now, that is fine for executing AppImages, but file thumbnailers such as KDE's Dolphin use libappimage.so directly to peek at the .DirIcon information, which fails for zstd images.

Would it be possible to add this support?

Arch Linux seems to enable fuse to get that support, squashfuse then needs to be compiled with zstd support turned on. That's a lot of switches that might or might not be enabled, depending on the distribution, and I think thumbnails should always be available in any case.

See my findings here,
ivan-hc/Steam-appimage#27 (comment)

So, I propose either,

  1. better zstd support out of the box,
  2. document what needs to be done if Thumbnails cannot be shown on some appimages (out of the box it would be fine with xz, zip images,
Squashfs image uses (null) compression, this version supports only xz, zlib.
ERROR: appimage_read_file_into_buffer_following_symlinks : sqfs_open_image error: /home/phil/Applications/Steam-1.0.0.81-2-3-x86_64.appimage

@probonopd
Copy link
Member

probonopd commented Sep 21, 2024

Hi @philmb3487, thanks for summarizing. This seems to be a feature request for libappimage then and should go here:

@probonopd probonopd changed the title Possible issue with Icons and Appimage's new runtime Add support for zstd compression to libappimage Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants