Apo 1022 seacoast search bar alignment #241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jimmyhogoboom
force-pushed
the
apo-1022-seacoast-search-bar-alignment
branch
from
1fd1f39 to
8013a52
Compare
|
@jimmyhogoboom this is supposed to close APO-1017. could you change the branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Issue
Closes #233
The profile popup width is based on the viewport width by default, and is absolutely positioned so its width isn't controlled by its container.
✏️ Solution
Implement a new data prop
data-search-profile-sizewhich takes a CSS width string, allowing the consumer to specify whatever width they need.Also nudge the popup to the right 15px to align it with the search bar.
🔬 To Test
📸 Screenshots