chore: update regex for more valid scripture feature references #155
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@vinnyjth I will work on this description. Discovered this issue while hooking up ScriptureFeatures on Admin. I dropped the before/after photos in the description already. Ideally, I think I would also like to make sure the padding/margin around scripture features on |
|
@nlewis84 Sounds good! long term, I wonder if we should expose this from the API :D |
Yeah, I think you are right on long term plan for it. |
| @@ -21,16 +21,37 @@ function ScriptureFeature(props = {}) { | |||
| }; | |||
|
|
|||
| function parseBibleReference(reference) { | |||
| const regex = /^([\w\s]+)\s(\d+):(\d+)-?(\d+)?$/; | |||
| // This regex handles cases like 'Genesis 1-3' and 'Genesis 1:1-3:24' | |||
| const regex = /^([\w\s]+)\s(\d+)(?::(\d+))?(?:-(\d+)(?::(\d+))?)?$/; | |||
| @@ -7,19 +7,27 @@ import { TypeStyles } from '../Typography'; | |||
| const Longform = styled.div` | |||
| ${TypeStyles.BodyText}; | |||
| max-width: 700px; | |||
| margin-bottom: ${themeGet('space.xl')}; | |||
There was a problem hiding this comment.
thanks for throwing these style updates in!
There was a problem hiding this comment.
Yep! Very obvious compared to this before shot:
🐛 Issue
Some scripture features are bombing out in
web-embedsbut not in mobile/admin✏️ Solution
web-embeds🔬 To Test
micro-servicebyyarn devin the/micro-servicefolder📸 Screenshots
After photos for mobile and web to show parity