Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review actions performed after component unmounts (cleanup react errors) #25

Open
underfisk opened this issue Feb 9, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@underfisk
Copy link
Collaborator

There might be some parts that are attempting to perform some kind of update when the component unmounts or has an invalid/outdated state, i have to review those parts to avoid leaks

@underfisk underfisk self-assigned this Feb 9, 2021
@underfisk
Copy link
Collaborator Author

Stack error example:

eval | @ | useKeyboard.js?76d1:77
  | eval | @ | ApolloSpreadsheet.js?5c34:formatted:112
  | eval | @ | ApolloSpreadsheet.js?5c34:formatted:128
  | eval | @ | ClickAwayListener.js?15d1:91
  | eval | @ | useEventCallback.js?4234:14

It seems to be happening on-grid clear focus, we should use a ref rather than a state for isFocused and also ensure that we only set state if component is mounted

@underfisk underfisk added the bug Something isn't working label May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant