feat: show snekmate working #51
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
commented
Sep 24, 2024
| "dependencies": [ | ||
| { | ||
| "pypi": "snekmate", | ||
| "config_override": {"base_path": "src", "contracts_folder": "snekmate"}, |
There was a problem hiding this comment.
So one goal of mine is to get Ape able to detect this config from projects like snekmate.
I am not 100% sure on how to do that yet. For now, may have to hardcode it in the hosted-compiler
There was a problem hiding this comment.
Great goal for us, but keep in mind that likely remix may have a set of whitelisted dependencies here w.r.t. snekmate (maybe not whitelist the version, but how the object is formed otherwise)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
snekmatedependencythis pr is intended to demo the bugfix but also may be a template for actually implementing the feature here.
Requires: ApeWorX/ape-vyper#132
How I did it
How to verify it
Checklist