Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trans_masks is None #1

Open
9shaw opened this issue Sep 9, 2024 · 6 comments
Open

trans_masks is None #1

9shaw opened this issue Sep 9, 2024 · 6 comments

Comments

@9shaw
Copy link

9shaw commented Sep 9, 2024

Hi, thanks for sharing, I tried setting Use_eval to True and then running this code on my computer, but had some problems.
image
This seems to indicate that in r_actor_critic.py trans_masks is None,It has bothered me for a long time, I really hope to hear your reply. Much thanks!

@AnonymousAccountss
Copy link
Owner

please replace your file path:
your_conda_env_path/lib/python3.8/site-packages/torch/nn/modules/transformer.py
with this file:
https://github.com/AnonymousAccountss/CoSLight/blob/master/transformer.py】

@9shaw
Copy link
Author

9shaw commented Sep 10, 2024

I have replaced the file as you did, unfortunately the problem persists, can you help me with this again, thanks!
image

@AnonymousAccountss
Copy link
Owner

Sorry, I misunderstood your question, please use_eval set False, we do not use this parameter in this codebase.

@9shaw
Copy link
Author

9shaw commented Sep 12, 2024

Hi, I would like to ask you how to calculate the Average Trip Time in your paper. If you could tell me, I would appreciate it!

@twodog0508
Copy link

Hello! Have you successfully reproduced the code? I tried running code in the Gird4x4 environment, but the results were different from the paper. The reward was less than -0.251. Do I need to modify some parameters?

@9shaw
Copy link
Author

9shaw commented Nov 28, 2024

Hello! Have you successfully reproduced the code? I tried running code in the Gird4x4 environment, but the results were different from the paper. The reward was less than -0.251. Do I need to modify some parameters?

Sorry, I haven't solved this problem yet, but I'm going to try to keep trying lately, so if you'd like, we can talk about it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants