-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dealing with new examples or code changes #9
Comments
Using pull requests sounds the best option to me. |
Maybe it's a bit selfish, but I have also in mind, if one merges a pull request for someone, it appears as his contribution under "graph", not the one who actually contributed. So if I would suggest, that contributers who are member of AngularShowcase merge their pull requests self. |
I am a believer in PRs. Many projects I work on require two people from the core team, one who accepts the PR and reports it as "OK TO MERGE", a second who actually helps out and does the final merge. Either core team member could have merged, the extra set of eyes increases quality in the long term. |
@sclausen: I think you must have experience with someone not apply PRs correctly. The original author always retains credit unless there is some change to the PR by the person that does the merge. |
@briantopping could this occur, if there are two commits by different users in a PR? |
If the PR needs changes, comment at PR and let the author to change. The reviewer could just merge or give an OK to merge... |
I think @Bigous has the right path here to make sure everyone gets proper credit as well that the original author learns repository standards for future commits. |
I agree with @Bigous here as well 👍 |
I want to discuss, how we treat new stuff here.
For bigger changes, we should open issues first, but for smaller simple changes/additions, do we simply push to master, or do we create pull requests, discuss them and the proposer can, If he is member of AngularShowcase, merge it himself?
The text was updated successfully, but these errors were encountered: