Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Generic OIDC login auth #703

Open
michael-robbins opened this issue Mar 15, 2022 · 13 comments · May be fixed by #1975
Open

[FEATURE] Generic OIDC login auth #703

michael-robbins opened this issue Mar 15, 2022 · 13 comments · May be fixed by #1975
Labels
enhancement New feature or request

Comments

@michael-robbins
Copy link

Is your feature request related to a problem? Please describe.

Anyone self hosting this would have to store yet another username/password combination for their local user(s), like many others of us who self host apps, we might be running something like Keycloak or Authelia to centralise the authentication of our users.

Describe the solution you'd like
Ability to configure a Client ID & Client Secret as well as an OIDC auth domain that is used instead of Google, users who log in with this method and are not already registered will be automatically created (similar to the Google login functionality currently).

Describe alternatives you've considered
Possibly add a OIDC proxy/login page that forces user to be authenticated before being allowed to navigate to the website, but that authentication cannot be passed in/etc to the app, so it's kinda pointless.

@michael-robbins michael-robbins added the enhancement New feature or request label Mar 15, 2022
@github-actions
Copy link

This issue is stale because it has been open for 30 days with no activity. Remove the stale label or comment on this issue, otherwise it would be closed in 5 days.

@github-actions github-actions bot added the Stale label Apr 15, 2022
@michael-robbins
Copy link
Author

Not sure what the process to track feature requests is, but are github issues the right place?

@AmruthPillai
Copy link
Owner

This is most definitely the place, but I'm just not sure about what OIDC Auth is well enough to implement it within Reactive Resume's current authentication system. And also, it should be known that I would prioritize to implement features that would be useful on the both versions (managed + self-hosted) of the site than just the self-hosted one. If this does have more folks peeking interest, will reconsider implementing it.

@michael-robbins
Copy link
Author

Sorry late reply :)

Yeah that makes sense, having a quick poke around the code what we'd be after is a similar approach to https://github.com/AmruthPillai/Reactive-Resume/blob/main/server/src/auth/auth.service.ts#L110 but just using a more generic OIDC library than google's one, so that you can plug in a few extra variables like the auth endpoint!

If I get some time I can have a go, but I wouldn't hold my breath :D

@zkvvoob
Copy link

zkvvoob commented Feb 7, 2024

Hi, @AmruthPillai

Have you had a chance to implement this feature?

Thanks!

@nyhil116
Copy link

Not going to lie, I very much want to self host this for both myself and friends, but my own rule is that I won't host anything that doesn't have the ability to use SSO, so I hope this feature gets implemented at some point. It genuinely looks like an incredibly helpful and promising web app.

@JW-CH
Copy link

JW-CH commented Apr 6, 2024

Also interested in a OIDC. My concern is that anyone with the public url can create an account. Or is there a way to restict that?

@adnanjaw
Copy link

adnanjaw commented May 1, 2024

It would be fantastic to see this feature coming in the next releases!

@NiklasRosenkranz
Copy link

yeah OIDC would be nice to have

@AutoGitr
Copy link

AutoGitr commented May 6, 2024

Would love to see generic OIDC support implemented. Existing users in IDPs (Authentik here) would be able to login immediately, without having to create an account for something they may only use a handful of times.

@HugoFollic
Copy link

As a Authelia user, definitely a nice feature

@razin99 razin99 linked a pull request Jun 21, 2024 that will close this issue
1 task
@ThatJRadGuy
Copy link

Also keen on this feature!

@adnanjaw
Copy link

@AmruthPillai please have a look at the linked PR! Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants